models/version: Migrate Version::published_by() to async/await

Author: Turbo87

src/controllers/version/metadata.rs

@@ -100,10 +100,11 @@ pub async fn show(
 
     let mut conn = state.db_read().await?;
     let (version, krate) = version_and_crate(&mut conn, &crate_name, &version).await?;
+    let published_by = version.published_by(&mut conn).await?;
+
     spawn_blocking(move || {
         let conn: &mut AsyncConnectionWrapper<_> = &mut conn.into();
 
-        let published_by = version.published_by(conn)?;
         let actions = VersionOwnerAction::by_version(conn, &version)?;
 
         let version = EncodableVersion::from(version, &krate.name, published_by, actions);
@@ -146,10 +147,11 @@ pub async fn update(
     )
     .await?;
 
+    let published_by = version.published_by(&mut conn).await?;
+
     spawn_blocking(move || {
         let conn: &mut AsyncConnectionWrapper<_> = &mut conn.into();
 
-        let published_by = version.published_by(conn)?;
         let actions = VersionOwnerAction::by_version(conn, &version)?;
         let updated_version = EncodableVersion::from(version, &krate.name, published_by, actions);
         Ok(json!({ "version": updated_version }))

src/models/version.rs

@@ -55,11 +55,11 @@ impl Version {
 
     /// Gets the User who ran `cargo publish` for this version, if recorded.
     /// Not for use when you have a group of versions you need the publishers for.
-    pub fn published_by(&self, conn: &mut impl Conn) -> QueryResult<Option<User>> {
-        use diesel::RunQueryDsl;
+    pub async fn published_by(&self, conn: &mut AsyncPgConnection) -> QueryResult<Option<User>> {
+        use diesel_async::RunQueryDsl;
 
         match self.published_by {
-            Some(pb) => users::table.find(pb).first(conn).optional(),
+            Some(pb) => users::table.find(pb).first(conn).await.optional(),
             None => Ok(None),
         }
     }