Skip to content

Commit 3776296

Browse files
committed
Fix flaky tests
1 parent ac66678 commit 3776296

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

app/components/crate-sidebar.hbs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<section
22
local-class='sidebar'
33
aria-label="Crate metadata"
4+
data-test-id="crate-sidebar"
45
...attributes
56
>
67
<div local-class="metadata">

tests/acceptance/support-test.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { click, currentURL, fillIn, findAll } from '@ember/test-helpers';
1+
import { click, currentURL, fillIn, findAll, waitFor } from '@ember/test-helpers';
22
import { module, test } from 'qunit';
33

44
import percySnapshot from '@percy/ember';
@@ -205,6 +205,8 @@ test detail
205205
};
206206

207207
await visit('/crates/nanomsg');
208+
assert.strictEqual(currentURL(), '/crates/nanomsg');
209+
await waitFor('[data-test-id="crate-sidebar"]');
208210
await click('[data-test-id="link-crate-report"]');
209211
assert.strictEqual(currentURL(), '/support?crate=nanomsg&inquire=crate-violation');
210212
assert.dom('[data-test-id="crate-input"]').hasValue('nanomsg');

0 commit comments

Comments
 (0)