controllers/version/metadata: Move get_version_dependencies() to dedicated module

Author: Turbo87

src/controllers/version.rs

@@ -1,3 +1,4 @@
+pub mod dependencies;
 pub mod downloads;
 pub mod metadata;
 pub mod readme;

src/controllers/version/dependencies.rs

@@ -0,0 +1,44 @@
+use super::CrateVersionPath;
+use crate::app::AppState;
+use crate::models::Dependency;
+use crate::util::errors::AppResult;
+use crate::views::EncodableDependency;
+use axum_extra::json;
+use axum_extra::response::ErasedJson;
+use crates_io_database::schema::{crates, dependencies};
+use diesel::prelude::*;
+use diesel_async::RunQueryDsl;
+
+/// Get crate version dependencies.
+///
+/// This information can also be obtained directly from the index.
+///
+/// In addition to returning cached data from the index, this returns
+/// fields for `id`, `version_id`, and `downloads` (which appears to always
+/// be 0)
+#[utoipa::path(
+    get,
+    path = "/api/v1/crates/{name}/{version}/dependencies",
+    params(CrateVersionPath),
+    tag = "versions",
+    responses((status = 200, description = "Successful Response")),
+)]
+pub async fn get_version_dependencies(
+    state: AppState,
+    path: CrateVersionPath,
+) -> AppResult<ErasedJson> {
+    let mut conn = state.db_read().await?;
+    let version = path.load_version(&mut conn).await?;
+
+    let deps = Dependency::belonging_to(&version)
+        .inner_join(crates::table)
+        .select((Dependency::as_select(), crates::name))
+        .order((dependencies::optional, crates::name))
+        .load::<(Dependency, String)>(&mut conn)
+        .await?
+        .into_iter()
+        .map(|(dep, crate_name)| EncodableDependency::from_dep(dep, &crate_name))
+        .collect::<Vec<_>>();
+
+    Ok(json!({ "dependencies": deps }))
+}

src/controllers/version/metadata.rs

@@ -7,7 +7,6 @@
 use axum::Json;
 use axum_extra::json;
 use axum_extra::response::ErasedJson;
-use crates_io_database::schema::{crates, dependencies};
 use crates_io_worker::BackgroundJob;
 use diesel::prelude::*;
 use diesel_async::{AsyncPgConnection, RunQueryDsl};
@@ -19,12 +18,12 @@ use crate::app::AppState;
 use crate::auth::{AuthCheck, Authentication};
 use crate::models::token::EndpointScope;
 use crate::models::{
-    Crate, Dependency, NewVersionOwnerAction, Rights, Version, VersionAction, VersionOwnerAction,
+    Crate, NewVersionOwnerAction, Rights, Version, VersionAction, VersionOwnerAction,
 };
 use crate::rate_limiter::LimitedAction;
 use crate::schema::versions;
 use crate::util::errors::{bad_request, custom, AppResult};
-use crate::views::{EncodableDependency, EncodableVersion};
+use crate::views::EncodableVersion;
 use crate::worker::jobs::{SyncToGitIndex, SyncToSparseIndex, UpdateDefaultVersion};
 
 use super::CrateVersionPath;
@@ -39,40 +38,6 @@ pub struct VersionUpdateRequest {
     version: VersionUpdate,
 }
 
-/// Get crate version dependencies.
-///
-/// This information can also be obtained directly from the index.
-///
-/// In addition to returning cached data from the index, this returns
-/// fields for `id`, `version_id`, and `downloads` (which appears to always
-/// be 0)
-#[utoipa::path(
-    get,
-    path = "/api/v1/crates/{name}/{version}/dependencies",
-    params(CrateVersionPath),
-    tag = "versions",
-    responses((status = 200, description = "Successful Response")),
-)]
-pub async fn get_version_dependencies(
-    state: AppState,
-    path: CrateVersionPath,
-) -> AppResult<ErasedJson> {
-    let mut conn = state.db_read().await?;
-    let version = path.load_version(&mut conn).await?;
-
-    let deps = Dependency::belonging_to(&version)
-        .inner_join(crates::table)
-        .select((Dependency::as_select(), crates::name))
-        .order((dependencies::optional, crates::name))
-        .load::<(Dependency, String)>(&mut conn)
-        .await?
-        .into_iter()
-        .map(|(dep, crate_name)| EncodableDependency::from_dep(dep, &crate_name))
-        .collect::<Vec<_>>();
-
-    Ok(json!({ "dependencies": deps }))
-}
-
 /// Get crate version authors.
 ///
 /// This endpoint was deprecated by [RFC #3052](https://github.com/rust-lang/rfcs/pull/3052)

src/router.rs

@@ -38,7 +38,7 @@ pub fn build_axum_router(state: AppState) -> Router<()> {
             version::metadata::update_version
         ))
         .routes(routes!(version::readme::get_version_readme))
-        .routes(routes!(version::metadata::get_version_dependencies))
+        .routes(routes!(version::dependencies::get_version_dependencies))
         .routes(routes!(version::downloads::get_version_downloads))
         .routes(routes!(version::metadata::get_version_authors))
         .routes(routes!(krate::downloads::get_crate_downloads))