database: Change versions.crate_size to be NOT NULL (#9926)

Author: Turbo87

crates/crates_io_database/src/schema.rs

@@ -954,10 +954,10 @@ diesel::table! {
         license -> Nullable<Varchar>,
         /// The `crate_size` column of the `versions` table.
         ///
-        /// Its SQL type is `Nullable<Int4>`.
+        /// Its SQL type is `Int4`.
         ///
         /// (Automatically generated by Diesel.)
-        crate_size -> Nullable<Int4>,
+        crate_size -> Int4,
         /// The `published_by` column of the `versions` table.
         ///
         /// Its SQL type is `Nullable<Int4>`.

migrations/2024-11-14-094209_make-crate-size-not-null/down.sql

@@ -0,0 +1,2 @@
+alter table versions
+    alter column crate_size drop not null;

migrations/2024-11-14-094209_make-crate-size-not-null/up.sql

@@ -0,0 +1,2 @@
+alter table versions
+    alter column crate_size set not null;

src/models/default_versions.rs

@@ -256,6 +256,7 @@ mod tests {
                 versions::num.eq(num),
                 versions::num_no_build.eq(num),
                 versions::checksum.eq(""),
+                versions::crate_size.eq(0),
             ))
             .execute(conn)
             .unwrap();

src/models/version.rs

@@ -24,7 +24,7 @@ pub struct Version {
     pub features: serde_json::Value,
     pub yanked: bool,
     pub license: Option<String>,
-    pub crate_size: Option<i32>,
+    pub crate_size: i32,
     pub published_by: Option<i32>,
     pub checksum: String,
     pub links: Option<String>,

src/tests/routes/crates/read.rs

@@ -131,7 +131,7 @@ async fn version_size() {
         .iter()
         .find(|v| v.num == "1.0.0")
         .expect("Could not find v1.0.0");
-    assert_eq!(version1.crate_size, Some(158));
+    assert_eq!(version1.crate_size, 158);
 
     let version2 = crate_json
         .versions
@@ -140,7 +140,7 @@ async fn version_size() {
         .iter()
         .find(|v| v.num == "2.0.0")
         .expect("Could not find v2.0.0");
-    assert_eq!(version2.crate_size, Some(184));
+    assert_eq!(version2.crate_size, 184);
 }
 
 #[tokio::test(flavor = "multi_thread")]

src/tests/worker/rss/sync_crate_feed.rs

@@ -73,6 +73,7 @@ async fn create_version(
             versions::created_at.eq(publish_time),
             versions::updated_at.eq(publish_time),
             versions::checksum.eq("checksum"),
+            versions::crate_size.eq(0),
         ))
         .returning(versions::id)
         .get_result(conn)

src/tests/worker/rss/sync_updates_feed.rs

@@ -79,6 +79,7 @@ async fn create_version(
             versions::created_at.eq(publish_time),
             versions::updated_at.eq(publish_time),
             versions::checksum.eq("checksum"),
+            versions::crate_size.eq(0),
         ))
         .returning(versions::id)
         .get_result(conn)

src/views.rs

@@ -579,7 +579,7 @@ pub struct EncodableVersion {
     // NOTE: Used by shields.io, altering `license` requires a PR with shields.io
     pub license: Option<String>,
     pub links: EncodableVersionLinks,
-    pub crate_size: Option<i32>,
+    pub crate_size: i32,
     pub published_by: Option<EncodablePublicUser>,
     pub audit_actions: Vec<EncodableAuditAction>,
     pub checksum: String,
@@ -763,7 +763,7 @@ mod tests {
                 version_downloads: "".to_string(),
                 authors: "".to_string(),
             },
-            crate_size: Some(1234),
+            crate_size: 1234,
             checksum: String::new(),
             rust_version: None,
             has_lib: None,

src/worker/jobs/archive_version_downloads.rs

@@ -399,6 +399,7 @@ mod tests {
                 versions::num.eq(num),
                 versions::num_no_build.eq(num),
                 versions::checksum.eq(""),
+                versions::crate_size.eq(0),
             ))
             .returning(versions::id)
             .get_result(conn)