Skip to content

Commit 4d5ab5f

Browse files
committed
Convert .scopes-list to global CSS class
This prepares for the migration to ember-scoped-css, which does not support `composes`.
1 parent 63eaae0 commit 4d5ab5f

File tree

4 files changed

+4
-5
lines changed

4 files changed

+4
-5
lines changed

app/components/support/crate-report-form.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434

3535
<fieldset local-class="form-group" data-test-id="fieldset-reasons">
3636
<div class="form-group-name">Reasons</div>
37-
<ul role="list" local-class="reasons-list {{if this.reasonsInvalid "invalid"}}">
37+
<ul role="list" local-class="reasons-list" class="scopes-list {{if this.reasonsInvalid "invalid"}}">
3838
{{#each this.reasons as |option|}}
3939
<li>
4040
<label>

app/components/support/crate-report-form.module.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
}
2020

2121
.reasons-list {
22-
composes: scopes-list from '../../styles/settings/tokens/new.module.css';
2322
label {
2423
flex-wrap: nowrap;
2524
}

app/styles/settings/tokens/new.module.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,15 @@
5454
font-size: 0.9em;
5555
}
5656

57-
.scopes-list {
57+
:global(.scopes-list) {
5858
list-style: none;
5959
padding: 0;
6060
margin: 0;
6161
background-color: light-dark(white, #141413);
6262
border: 1px solid var(--gray-border);
6363
border-radius: var(--space-3xs);
6464

65-
&.invalid {
65+
&:global(.invalid) {
6666
background: light-dark(#fff2f2, #170808);
6767
border-color: red;
6868
}

app/templates/settings/tokens/new.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
</a>
9090
</div>
9191

92-
<ul role="list" local-class="scopes-list {{if this.scopesInvalid "invalid"}}">
92+
<ul role="list" class="scopes-list {{if this.scopesInvalid "invalid"}}">
9393
{{#each this.ENDPOINT_SCOPES as |scope|}}
9494
<li>
9595
<label data-test-scope={{scope}}>

0 commit comments

Comments
 (0)