app: Simplify releaseTrackSet using release_tracks meta

This eliminates the computation of `release_tracks` in the app and
fetches the computed meta from the backend once in the `versions` page.

Author: eth3lbert

app/controllers/crate/versions.js

@@ -52,6 +52,7 @@ export default class SearchController extends Controller {
     if (next_page) {
       let params = new URLSearchParams(next_page);
       params.set('name', crate.name);
+      params.delete('include');
       query = Object.fromEntries(params.entries());
     } else {
       if (sort !== 'semver') {
@@ -63,6 +64,9 @@ export default class SearchController extends Controller {
         per_page,
       };
     }
+    if (crate.release_tracks == null) {
+      query.include = 'release_tracks';
+    }
 
     try {
       let versions = await this.store.query('version', query);
@@ -82,6 +86,18 @@ export default class SearchController extends Controller {
           next_page: meta.next_page,
         };
       }
+
+      // set release_tracks to crate
+      if (meta.release_tracks) {
+        let payload = {
+          crate: {
+            id: crate.id,
+            release_tracks: meta.release_tracks,
+          },
+        };
+        this.store.pushPayload(payload);
+      }
+
       return versions;
     } catch (error) {
       // report unexpected errors to Sentry and ignore `ajax()` errors

app/models/crate.js

@@ -29,6 +29,14 @@ export default class Crate extends Model {
   @attr documentation;
   @attr repository;
 
+  /**
+   * This isn't an attribute in the crate response.
+   * It's actually the `meta` attribute that belongs to `versions`
+   * and needs to be assigned to `crate` manually.
+   * @type {Object.<string, {highest: string}>?}
+   **/
+  @attr release_tracks;
+
   @hasMany('version', { async: true, inverse: 'crate' }) versions;
   @hasMany('team', { async: true, inverse: null }) owner_team;
   @hasMany('user', { async: true, inverse: null }) owner_user;
@@ -68,15 +76,9 @@ export default class Crate extends Model {
   }
 
   @cached get releaseTrackSet() {
-    let map = new Map();
-    let { loadedVersionsById: versions, versionIdsBySemver } = this;
-    for (let id of versionIdsBySemver) {
-      let { releaseTrack, isPrerelease, yanked } = versions.get(id);
-      if (releaseTrack && !isPrerelease && !yanked && !map.has(releaseTrack)) {
-        map.set(releaseTrack, id);
-      }
-    }
-    return new Set(map.values());
+    let { release_tracks } = this;
+    let nums = release_tracks ? Object.values(this.release_tracks).map(it => it.highest) : [];
+    return new Set(nums);
   }
 
   hasOwnerUser(userId) {

app/models/version.js

@@ -102,7 +102,7 @@ export default class Version extends Model {
       return false;
     }
 
-    return this.crate?.releaseTrackSet.has(this.id);
+    return this.crate?.releaseTrackSet.has(this.num);
   }
 
   get featureList() {

tests/models/version-test.js

@@ -1,5 +1,7 @@
 import { module, test } from 'qunit';
 
+import { calculateReleaseTracks } from '@crates-io/msw/utils/release-tracks';
+
 import { setupTest } from 'crates-io/tests/helpers';
 import setupMsw from 'crates-io/tests/helpers/setup-msw';
 
@@ -169,6 +171,7 @@ module('Model | Version', function (hooks) {
 
       let crateRecord = await this.store.findRecord('crate', crate.name);
       let versions = (await crateRecord.loadVersionsTask.perform()).slice();
+      crateRecord.release_tracks = calculateReleaseTracks(versions);
 
       assert.deepEqual(
         versions.map(it => ({ num: it.num, isHighestOfReleaseTrack: it.isHighestOfReleaseTrack })),
@@ -200,6 +203,7 @@ module('Model | Version', function (hooks) {
 
       let crateRecord = await this.store.findRecord('crate', crate.name);
       let versions = (await crateRecord.loadVersionsTask.perform()).slice();
+      crateRecord.release_tracks = calculateReleaseTracks(versions);
 
       assert.deepEqual(
         versions.map(it => ({ num: it.num, isHighestOfReleaseTrack: it.isHighestOfReleaseTrack })),
@@ -218,6 +222,7 @@ module('Model | Version', function (hooks) {
 
       let crateRecord = await this.store.findRecord('crate', crate.name);
       let versions = (await crateRecord.loadVersionsTask.perform()).slice();
+      crateRecord.release_tracks = calculateReleaseTracks(versions);
 
       assert.deepEqual(
         versions.map(it => ({ num: it.num, isHighestOfReleaseTrack: it.isHighestOfReleaseTrack })),
@@ -231,6 +236,7 @@ module('Model | Version', function (hooks) {
       this.db.version.create({ crate, num: '0.4.3', yanked: true });
       crateRecord = await this.store.findRecord('crate', crate.name, { reload: true });
       versions = (await crateRecord.loadVersionsTask.perform({ reload: true })).slice();
+      crateRecord.release_tracks = calculateReleaseTracks(versions);
 
       assert.deepEqual(
         versions.map(it => ({ num: it.num, isHighestOfReleaseTrack: it.isHighestOfReleaseTrack })),