routes/application: Show banner message if it is set

Author: Turbo87

app/routes/application.js

@@ -64,13 +64,16 @@ export default class ApplicationRoute extends Route {
     let timeout = Ember.testing ? 0 : 1000;
     await rawTimeout(timeout);
 
-    let { read_only: readOnly } = await ajax('/api/v1/site_metadata');
-    if (readOnly) {
-      let message =
+    let { read_only, banner_message } = await ajax('/api/v1/site_metadata');
+
+    if (!banner_message && read_only) {
+      banner_message =
         'crates.io is currently in read-only mode for maintenance reasons. ' +
         'Some functionality will be temporarily unavailable.';
+    }
 
-      this.notifications.info(message, { autoClear: false });
+    if (banner_message) {
+      this.notifications.info(banner_message, { autoClear: false });
     }
   });
 

e2e/acceptance/read-only-mode.spec.ts

@@ -39,6 +39,25 @@ test.describe('Acceptance | Read-only Mode', { tag: '@acceptance' }, () => {
     await checkSentryEventsNumber(ember, 1);
     await checkSentryEventsHasName(ember, ['AjaxError']);
   });
+
+  test('banner message is shown when present', async ({ page, msw }) => {
+    await msw.worker.use(
+      http.get('/api/v1/site_metadata', () => HttpResponse.json({ banner_message: 'test message' })),
+    );
+    await page.goto('/');
+
+    await expect(page.locator('[data-test-notification-message="info"]')).toContainText('test message');
+  });
+
+  test('banner message takes precedence over read-only mode', async ({ page, msw }) => {
+    await msw.worker.use(
+      http.get('/api/v1/site_metadata', () => HttpResponse.json({ read_only: true, banner_message: 'test message' })),
+    );
+    await page.goto('/');
+
+    await expect(page.locator('[data-test-notification-message="info"]')).toContainText('test message');
+    await expect(page.locator('[data-test-notification-message="info"]')).not.toContainText('read-only mode');
+  });
 });
 
 async function checkSentryEventsNumber(ember: AppFixtures['ember'], expected: number) {

tests/acceptance/read-only-mode-test.js

@@ -38,4 +38,21 @@ module('Acceptance | Read-only Mode', function (hooks) {
     assert.deepEqual(this.owner.lookup('service:sentry').events.length, 1);
     assert.true(this.owner.lookup('service:sentry').events[0].error instanceof AjaxError);
   });
+
+  test('banner message is shown when present', async function (assert) {
+    this.worker.use(http.get('/api/v1/site_metadata', () => HttpResponse.json({ banner_message: 'test message' })));
+
+    await visit('/');
+    assert.dom('[data-test-notification-message="info"]').includesText('test message');
+  });
+
+  test('banner message takes precedence over read-only mode', async function (assert) {
+    this.worker.use(
+      http.get('/api/v1/site_metadata', () => HttpResponse.json({ read_only: true, banner_message: 'test message' })),
+    );
+
+    await visit('/');
+    assert.dom('[data-test-notification-message="info"]').includesText('test message');
+    assert.dom('[data-test-notification-message="info"]').doesNotIncludeText('read-only mode');
+  });
 });