mirage: Add missing msg fields to the add owner endpoint responses

Author: Turbo87

mirage/route-handlers/crates.js

@@ -243,6 +243,7 @@ export function register(server) {
 
     let users = [];
     let teams = [];
+    let msgs = [];
     for (let login of body.owners) {
       if (login.includes(':')) {
         let team = schema.teams.findBy({ login });
@@ -251,13 +252,15 @@ export function register(server) {
         }
 
         teams.push(team);
+        msgs.push(`team ${login} has been added as an owner of crate ${crate.name}`);
       } else {
         let user = schema.users.findBy({ login });
         if (!user) {
           return new Response(404, {}, { errors: [{ detail: `could not find user with login \`${login}\`` }] });
         }
 
         users.push(user);
+        msgs.push(`user ${login} has been invited to be an owner of crate ${crate.name}`);
       }
     }
 
@@ -269,7 +272,8 @@ export function register(server) {
       schema.crateOwnerInvitations.create({ crate, inviter: user, invitee });
     }
 
-    return { ok: true };
+    let msg = msgs.join(',');
+    return { ok: true, msg };
   });
 
   server.delete('/api/v1/crates/:name/owners', (schema, request) => {

tests/mirage/crates/add-owner-test.js

@@ -40,7 +40,10 @@ module('Mirage | PUT /api/v1/crates/:name/owners', function (hooks) {
     let body = JSON.stringify({ owners: [user2.login] });
     let response = await fetch('/api/v1/crates/foo/owners', { method: 'PUT', body });
     assert.strictEqual(response.status, 200);
-    assert.deepEqual(await response.json(), { ok: true });
+    assert.deepEqual(await response.json(), {
+      ok: true,
+      msg: 'user user-2 has been invited to be an owner of crate foo',
+    });
 
     let owners = this.server.schema.crateOwnerships.where({ crateId: crate.id });
     assert.strictEqual(owners.length, 1);
@@ -64,7 +67,10 @@ module('Mirage | PUT /api/v1/crates/:name/owners', function (hooks) {
     let body = JSON.stringify({ owners: [team.login] });
     let response = await fetch('/api/v1/crates/foo/owners', { method: 'PUT', body });
     assert.strictEqual(response.status, 200);
-    assert.deepEqual(await response.json(), { ok: true });
+    assert.deepEqual(await response.json(), {
+      ok: true,
+      msg: 'team github:rust-lang:team-1 has been added as an owner of crate foo',
+    });
 
     let owners = this.server.schema.crateOwnerships.where({ crateId: crate.id });
     assert.strictEqual(owners.length, 2);
@@ -91,7 +97,10 @@ module('Mirage | PUT /api/v1/crates/:name/owners', function (hooks) {
     let body = JSON.stringify({ owners: [user2.login, team.login, user3.login] });
     let response = await fetch('/api/v1/crates/foo/owners', { method: 'PUT', body });
     assert.strictEqual(response.status, 200);
-    assert.deepEqual(await response.json(), { ok: true });
+    assert.deepEqual(await response.json(), {
+      ok: true,
+      msg: 'user user-2 has been invited to be an owner of crate foo,team github:rust-lang:team-1 has been added as an owner of crate foo,user user-3 has been invited to be an owner of crate foo',
+    });
 
     let owners = this.server.schema.crateOwnerships.where({ crateId: crate.id });
     assert.strictEqual(owners.length, 2);

tests/models/crate-test.js

@@ -25,7 +25,7 @@ module('Model | Crate', function (hooks) {
       let crateRecord = await this.store.findRecord('crate', crate.name);
 
       let result = await crateRecord.inviteOwner(user2.login);
-      assert.deepEqual(result, { ok: true });
+      assert.deepEqual(result, { ok: true, msg: 'user user-2 has been invited to be an owner of crate crate-0' });
     });
 
     test('error handling', async function (assert) {