controllers/krate/publish: Extract duplicate_version_error() fn

Author: Turbo87

src/controllers/krate/publish.rs

@@ -376,10 +376,8 @@ pub async fn publish(app: AppState, req: BytesRequest) -> AppResult<Json<GoodCra
             let version = new_version.save(conn, &verified_email_address).map_err(|error| {
                 use diesel::result::{Error, DatabaseErrorKind};
                 match error {
-                    Error::DatabaseError(DatabaseErrorKind::UniqueViolation, _) => bad_request(format_args!(
-                        "crate version `{}` is already uploaded",
-                        new_version.num_no_build
-                    )),
+                    Error::DatabaseError(DatabaseErrorKind::UniqueViolation, _) =>
+                        duplicate_version_error(new_version.num_no_build),
                     error => error.into(),
                 }
             })?;
@@ -620,6 +618,10 @@ fn missing_metadata_error_message(missing: &[&str]) -> String {
     )
 }
 
+fn duplicate_version_error(version: &str) -> BoxedAppError {
+    bad_request(format!("crate version `{version}` is already uploaded"))
+}
+
 fn validate_rust_version(value: &str) -> AppResult<()> {
     match semver::VersionReq::parse(value) {
         // Exclude semver operators like `^` and pre-release identifiers