typosquat/test_util: Remove unused Version from crate_and_version() return type

Author: Turbo87

src/typosquat/database.rs

@@ -183,8 +183,8 @@ mod tests {
 
         // Let's set up a team that owns both b and c, but not a.
         let not_the_a_team = faker::team(&mut conn, "org", "team")?;
-        faker::add_crate_to_team(&mut conn, &user_b, &top_b.0, &not_the_a_team)?;
-        faker::add_crate_to_team(&mut conn, &user_b, &not_top_c.0, &not_the_a_team)?;
+        faker::add_crate_to_team(&mut conn, &user_b, &top_b, &not_the_a_team)?;
+        faker::add_crate_to_team(&mut conn, &user_b, &not_top_c, &not_the_a_team)?;
 
         let top_crates = TopCrates::new(&mut conn, 2)?;
 

src/typosquat/test_util.rs

@@ -38,7 +38,7 @@ pub mod faker {
         description: &str,
         user: &User,
         downloads: i32,
-    ) -> anyhow::Result<(Crate, Version)> {
+    ) -> anyhow::Result<Crate> {
         let krate = NewCrate {
             name,
             description: Some(description),
@@ -51,14 +51,14 @@ pub mod faker {
             .set(crate_downloads::downloads.eq(downloads as i64))
             .execute(conn)?;
 
-        let version = NewVersion::builder(krate.id, "1.0.0")
+        NewVersion::builder(krate.id, "1.0.0")
             .published_by(user.id)
             .checksum("0000000000000000000000000000000000000000000000000000000000000000")
             .build()
             .save(conn, "[email protected]")
             .unwrap();
 
-        Ok((krate, version))
+        Ok(krate)
     }
 
     pub fn team(conn: &mut PgConnection, org: &str, team: &str) -> anyhow::Result<Owner> {

src/worker/jobs/typosquat.rs

@@ -141,14 +141,14 @@ mod tests {
 
         // Now we'll create new crates: one problematic, one not so.
         let other_user = faker::user(&mut conn, "b")?;
-        let (angel, _version) = faker::crate_and_version(
+        let angel = faker::crate_and_version(
             &mut conn,
             "innocent-crate",
             "I'm just a simple, innocent crate",
             &other_user,
             0,
         )?;
-        let (demon, _version) = faker::crate_and_version(
+        let demon = faker::crate_and_version(
             &mut conn,
             "mycrate",
             "I'm even more innocent, obviously",