models/crate: Load crate.versions explicitly with a task

A debugging assert is also included to inform missing `perform()` called
before accessing getters.

This fix the following deprecations:
- The toArray method on ember-data's PromiseManyArray is deprecated.
- The `toArray` method on the class ManyArray is deprecated.

Author: eth3lbert

app/models/crate.js

@@ -37,22 +37,34 @@ export default class Crate extends Model {
   @hasMany('dependency', { async: true, inverse: null }) reverse_dependencies;
 
   @cached get versionIdsBySemver() {
-    let versions = this.versions.toArray() ?? [];
-    return versions.sort(compareVersionBySemver).map(v => v.id);
+    let { last } = this.loadVersionsTask;
+    assert('`loadVersionsTask.perform()` must be called before calling `versionIdsBySemver`', last != null);
+    let versions = last?.value ?? [];
+    return versions
+      .slice()
+      .sort(compareVersionBySemver)
+      .map(v => v.id);
   }
 
   @cached get versionIdsByDate() {
-    let versions = this.versions.toArray() ?? [];
-    return versions.sort(compareVersionByDate).map(v => v.id);
+    let { last } = this.loadVersionsTask;
+    assert('`loadVersionsTask.perform()` must be called before calling `versionIdsByDate`', last != null);
+    let versions = last?.value ?? [];
+    return versions
+      .slice()
+      .sort(compareVersionByDate)
+      .map(v => v.id);
   }
 
   @cached get firstVersionId() {
     return this.versionIdsByDate.at(-1);
   }
 
   @cached get versionsObj() {
-    let versions = this.versions.toArray() ?? [];
-    return Object.fromEntries(versions.map(v => [v.id, v]));
+    let { last } = this.loadVersionsTask;
+    assert('`loadVersionsTask.perform()` must be called before calling `versionsObj`', last != null);
+    let versions = last?.value ?? [];
+    return Object.fromEntries(versions.slice().map(v => [v.id, v]));
   }
 
   @cached get releaseTrackSet() {
@@ -117,6 +129,10 @@ export default class Crate extends Model {
     let [teams, users] = await Promise.all([this.owner_team, this.owner_user]);
     return [...(teams ?? []), ...(users ?? [])];
   });
+
+  loadVersionsTask = task(async () => {
+    return (await this.versions) ?? [];
+  });
 }
 
 function compareVersionBySemver(a, b) {

app/routes/crate/versions.js

@@ -0,0 +1,12 @@
+import Route from '@ember/routing/route';
+import { waitForPromise } from '@ember/test-waiters';
+
+export default class VersionsRoute extends Route {
+  setupController(controller) {
+    super.setupController(...arguments);
+    let crate = this.modelFor('crate');
+    controller.set('crate', crate);
+    // TODO: Add error handling
+    waitForPromise(crate.loadVersionsTask.perform());
+  }
+}

tests/components/version-list-row-test.js

@@ -18,7 +18,7 @@ module('Component | VersionList::Row', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     let crateRecord = await store.findRecord('crate', crate.name);
-    let versions = (await crateRecord.versions).slice();
+    let versions = (await crateRecord.loadVersionsTask.perform()).slice();
     await crateRecord.loadOwnerUserTask.perform();
     this.firstVersion = versions[0];
     this.secondVersion = versions[1];
@@ -39,7 +39,7 @@ module('Component | VersionList::Row', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     let crateRecord = await store.findRecord('crate', crate.name);
-    this.version = (await crateRecord.versions).slice()[0];
+    this.version = (await crateRecord.loadVersionsTask.perform()).slice()[0];
     await crateRecord.loadOwnerUserTask.perform();
 
     await render(hbs`<VersionList::Row @version={{this.version}} />`);
@@ -73,7 +73,7 @@ module('Component | VersionList::Row', function (hooks) {
 
     let store = this.owner.lookup('service:store');
     let crateRecord = await store.findRecord('crate', crate.name);
-    let versions = (await crateRecord.versions).slice();
+    let versions = (await crateRecord.loadVersionsTask.perform()).slice();
     await crateRecord.loadOwnerUserTask.perform();
     this.firstVersion = versions[0];
     this.secondVersion = versions[1];

tests/models/version-test.js

@@ -167,7 +167,7 @@ module('Model | Version', function (hooks) {
       }
 
       let crateRecord = await this.store.findRecord('crate', crate.name);
-      let versions = (await crateRecord.versions).slice();
+      let versions = (await crateRecord.loadVersionsTask.perform()).slice();
 
       assert.deepEqual(
         versions.map(it => ({ num: it.num, isHighestOfReleaseTrack: it.isHighestOfReleaseTrack })),
@@ -198,7 +198,7 @@ module('Model | Version', function (hooks) {
       this.server.create('version', { crate, num: '0.4.2', yanked: true });
 
       let crateRecord = await this.store.findRecord('crate', crate.name);
-      let versions = (await crateRecord.versions).slice();
+      let versions = (await crateRecord.loadVersionsTask.perform()).slice();
 
       assert.deepEqual(
         versions.map(it => ({ num: it.num, isHighestOfReleaseTrack: it.isHighestOfReleaseTrack })),
@@ -216,7 +216,7 @@ module('Model | Version', function (hooks) {
       this.server.create('version', { crate, num: '0.4.1' });
 
       let crateRecord = await this.store.findRecord('crate', crate.name);
-      let versions = (await crateRecord.versions).slice();
+      let versions = (await crateRecord.loadVersionsTask.perform()).slice();
 
       assert.deepEqual(
         versions.map(it => ({ num: it.num, isHighestOfReleaseTrack: it.isHighestOfReleaseTrack })),
@@ -229,7 +229,7 @@ module('Model | Version', function (hooks) {
       this.server.create('version', { crate, num: '0.4.2' });
       this.server.create('version', { crate, num: '0.4.3', yanked: true });
       crateRecord = await this.store.findRecord('crate', crate.name, { reload: true });
-      versions = (await crateRecord.versions).slice();
+      versions = (await crateRecord.loadVersionsTask.perform()).slice();
 
       assert.deepEqual(
         versions.map(it => ({ num: it.num, isHighestOfReleaseTrack: it.isHighestOfReleaseTrack })),