mirage: Fix "version not found" errors to 404 status code

Author: eth3lbert

mirage/route-handlers/crates.js

@@ -174,7 +174,12 @@ export function register(server) {
 
     let num = request.params.version_num;
     let version = schema.versions.findBy({ crateId: crate.id, num });
-    if (!version) return { errors: [{ detail: `crate \`${crate.name}\` does not have a version \`${num}\`` }] };
+    if (!version)
+      return new Response(
+        404,
+        {},
+        { errors: [{ detail: `crate \`${crate.name}\` does not have a version \`${num}\`` }] },
+      );
 
     return { meta: { names: [] }, users: [] };
   });
@@ -186,7 +191,12 @@ export function register(server) {
 
     let num = request.params.version_num;
     let version = schema.versions.findBy({ crateId: crate.id, num });
-    if (!version) return { errors: [{ detail: `crate \`${crate.name}\` does not have a version \`${num}\`` }] };
+    if (!version)
+      return new Response(
+        404,
+        {},
+        { errors: [{ detail: `crate \`${crate.name}\` does not have a version \`${num}\`` }] },
+      );
 
     return schema.dependencies.where({ versionId: version.id });
   });
@@ -196,9 +206,14 @@ export function register(server) {
     let crate = schema.crates.findBy({ name });
     if (!crate) return notFound();
 
-    let versionNum = request.params.version_num;
-    let version = schema.versions.findBy({ crateId: crate.id, num: versionNum });
-    if (!version) return { errors: [{ detail: `crate \`${crate.name}\` does not have a version \`${versionNum}\`` }] };
+    let num = request.params.version_num;
+    let version = schema.versions.findBy({ crateId: crate.id, num });
+    if (!version)
+      return new Response(
+        404,
+        {},
+        { errors: [{ detail: `crate \`${crate.name}\` does not have a version \`${num}\`` }] },
+      );
 
     return schema.versionDownloads.where({ versionId: version.id });
   });

tests/mirage/crates/versions/authors-test.js

@@ -15,13 +15,11 @@ module('Mirage | GET /api/v1/crates/:id/:version/authors', function (hooks) {
     assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] });
   });
 
-  test('returns 200 for unknown versions', async function (assert) {
+  test('returns 404 for unknown versions', async function (assert) {
     this.server.create('crate', { name: 'rand' });
 
     let response = await fetch('/api/v1/crates/rand/1.0.0/authors');
-    // we should probably return 404 for this, but the production API
-    // currently doesn't do this either
-    assert.strictEqual(response.status, 200);
+    assert.strictEqual(response.status, 404);
     assert.deepEqual(await response.json(), { errors: [{ detail: 'crate `rand` does not have a version `1.0.0`' }] });
   });
 

tests/mirage/crates/versions/dependencies-test.js

@@ -15,13 +15,11 @@ module('Mirage | GET /api/v1/crates/:id/:version/dependencies', function (hooks)
     assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] });
   });
 
-  test('returns 200 for unknown versions', async function (assert) {
+  test('returns 404 for unknown versions', async function (assert) {
     this.server.create('crate', { name: 'rand' });
 
     let response = await fetch('/api/v1/crates/rand/1.0.0/dependencies');
-    // we should probably return 404 for this, but the production API
-    // currently doesn't do this either
-    assert.strictEqual(response.status, 200);
+    assert.strictEqual(response.status, 404);
     assert.deepEqual(await response.json(), { errors: [{ detail: 'crate `rand` does not have a version `1.0.0`' }] });
   });
 

tests/mirage/crates/versions/downloads-test.js

@@ -15,13 +15,11 @@ module('Mirage | GET /api/v1/crates/:id/:version/downloads', function (hooks) {
     assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] });
   });
 
-  test('returns 200 for unknown versions', async function (assert) {
+  test('returns 404 for unknown versions', async function (assert) {
     this.server.create('crate', { name: 'rand' });
 
     let response = await fetch('/api/v1/crates/rand/1.0.0/downloads');
-    // we should probably return 404 for this, but the production API
-    // currently doesn't do this either
-    assert.strictEqual(response.status, 200);
+    assert.strictEqual(response.status, 404);
     assert.deepEqual(await response.json(), { errors: [{ detail: 'crate `rand` does not have a version `1.0.0`' }] });
   });