Skip to content

Commit a109beb

Browse files
authored
Merge pull request #10144 from Turbo87/support-buttons
Include email address in support buttons
2 parents cb7c5e8 + de7f217 commit a109beb

File tree

6 files changed

+18
-13
lines changed

6 files changed

+18
-13
lines changed

app/components/support/crate-report-form.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@
8383
local-class="report-button"
8484
data-test-id="report-button"
8585
>
86-
Report
86+
Report to <strong>[email protected]</strong>
8787
</button>
8888
</div>
8989
</form>

app/components/support/crate-report-form.module.css

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,10 @@
6767
composes: button;
6868
composes: button small from '../../styles/shared/buttons.module.css';
6969
border-radius: var(--space-3xs);
70-
}
70+
font-weight: normal;
7171

72-
.cancel-button {
73-
composes: button;
74-
composes: tan-button small from '../../styles/shared/buttons.module.css';
75-
border-radius: var(--space-3xs);
72+
strong {
73+
margin-left: var(--space-3xs);
74+
font-weight: 500;
75+
}
7676
}

app/styles/support.module.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,9 @@
1212
padding: var(--space-xs) var(--space-s);
1313
height: inherit;
1414
min-height: var(--space-2xl);
15+
16+
strong {
17+
margin-left: var(--space-3xs);
18+
font-weight: 500;
19+
}
1520
}

app/templates/support.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
data-test-id="link-email-support"
3030
local-class="link"
3131
>
32-
For all other cases
32+
For all other cases: <strong>[email protected]</strong>
3333
</a>
3434
</li>
3535
</ul>

e2e/acceptance/support.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ test.describe('Acceptance | support page', { tag: '@acceptance' }, () => {
1010
const inquireList = page.getByTestId('inquire-list');
1111
await expect(inquireList).toBeVisible();
1212
await expect(inquireList.locator(page.getByRole('listitem'))).toHaveText(
13-
['Report a crate that violates policies'].concat(['For all other cases']),
13+
['Report a crate that violates policies'].concat(['For all other cases: [email protected]']),
1414
);
1515

1616
await percy.snapshot();
@@ -26,7 +26,7 @@ test.describe('Acceptance | support page', { tag: '@acceptance' }, () => {
2626
const inquireList = page.getByTestId('inquire-list');
2727
await expect(inquireList).toBeVisible();
2828
await expect(inquireList.locator(page.getByRole('listitem'))).toHaveText(
29-
['Report a crate that violates policies'].concat(['For all other cases']),
29+
['Report a crate that violates policies'].concat(['For all other cases: [email protected]']),
3030
);
3131
});
3232

@@ -57,7 +57,7 @@ test.describe('Acceptance | support page', { tag: '@acceptance' }, () => {
5757
await expect(page.getByTestId('fieldset-crate')).toBeVisible();
5858
await expect(page.getByTestId('fieldset-reasons')).toBeVisible();
5959
await expect(page.getByTestId('fieldset-detail')).toBeVisible();
60-
await expect(page.getByTestId('report-button')).toHaveText('Report');
60+
await expect(page.getByTestId('report-button')).toHaveText('Report to [email protected]');
6161

6262
await percy.snapshot();
6363
await a11y.audit();

tests/acceptance/support-test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ module('Acceptance | support', function (hooks) {
2424
const listitem = findAll('[data-test-id="inquire-list"] li');
2525
assert.deepEqual(
2626
listitem.map(item => item.textContent.trim()),
27-
['Report a crate that violates policies'].concat(['For all other cases']),
27+
['Report a crate that violates policies'].concat(['For all other cases: [email protected]']),
2828
);
2929

3030
await percySnapshot(assert);
@@ -41,7 +41,7 @@ module('Acceptance | support', function (hooks) {
4141
const listitem = findAll('[data-test-id="inquire-list"] li');
4242
assert.deepEqual(
4343
listitem.map(item => item.textContent.trim()),
44-
['Report a crate that violates policies'].concat(['For all other cases']),
44+
['Report a crate that violates policies'].concat(['For all other cases: [email protected]']),
4545
);
4646
});
4747

@@ -71,7 +71,7 @@ module('Acceptance | support', function (hooks) {
7171
assert.dom('[data-test-id="fieldset-crate"]').exists();
7272
assert.dom('[data-test-id="fieldset-reasons"]').exists();
7373
assert.dom('[data-test-id="fieldset-detail"]').exists();
74-
assert.dom('[data-test-id="report-button"]').hasText('Report');
74+
assert.dom('[data-test-id="report-button"]').hasText('Report to [email protected]');
7575

7676
await percySnapshot(assert);
7777
await a11yAudit(axeConfig);

0 commit comments

Comments
 (0)