mirage: Add multiple ids[] parameters support for GET /api/v1/crates/:id/versions

Author: eth3lbert

mirage/route-handlers/crates.js

@@ -153,7 +153,12 @@ export function register(server) {
     let crate = schema.crates.findBy({ name });
     if (!crate) return notFound();
 
-    let versions = crate.versions.sort((a, b) => compareIsoDates(b.created_at, a.created_at));
+    let versions = crate.versions;
+    let { ids } = request.queryParams;
+    if (ids) {
+      versions = versions.filter(version => ids.includes(version.num));
+    }
+    versions = versions.sort((a, b) => compareIsoDates(b.created_at, a.created_at));
     let total = versions.length;
     let include = request.queryParams?.include ?? '';
     let release_tracks = include.split(',').includes('release_tracks') && releaseTracks(crate.versions);

tests/mirage/crates/versions/list-test.js

@@ -108,6 +108,21 @@ module('Mirage | GET /api/v1/crates/:id/versions', function (hooks) {
     });
   });
 
+  test('supports multiple `ids[]` parameters', async function (assert) {
+    let user = this.server.create('user');
+    let crate = this.server.create('crate', { name: 'rand' });
+    this.server.create('version', { crate, num: '1.0.0' });
+    this.server.create('version', { crate, num: '1.1.0', publishedBy: user });
+    this.server.create('version', { crate, num: '1.2.0', rust_version: '1.69' });
+    let response = await fetch('/api/v1/crates/rand/versions?ids[]=1.0.0&ids[]=1.2.0');
+    assert.strictEqual(response.status, 200);
+    let json = await response.json();
+    assert.deepEqual(
+      json.versions.map(v => v.num),
+      ['1.0.0', '1.2.0'],
+    );
+  });
+
   test('include `release_tracks` meta', async function (assert) {
     let user = this.server.create('user');
     let crate = this.server.create('crate', { name: 'rand' });