Replace Error::new(ErrorKind::Other, ...) with Error::other(...)

Author: Turbo87

crates/crates_io_tarball/src/limit_reader.rs

@@ -25,10 +25,9 @@ impl<R: AsyncRead + Unpin> AsyncRead for LimitErrorReader<R> {
     ) -> Poll<io::Result<()>> {
         let reader = Pin::new(&mut self.inner);
         match reader.poll_read(cx, buf) {
-            Poll::Ready(Ok(())) if self.inner.limit() == 0 => Poll::Ready(Err(io::Error::new(
-                io::ErrorKind::Other,
-                "maximum limit reached when reading",
-            ))),
+            Poll::Ready(Ok(())) if self.inner.limit() == 0 => {
+                Poll::Ready(Err(io::Error::other("maximum limit reached when reading")))
+            }
             e => e,
         }
     }

src/bin/crates-admin/render_readmes.rs

@@ -169,9 +169,7 @@ async fn get_readme(
         ));
     }
 
-    let reader = response
-        .bytes_stream()
-        .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e));
+    let reader = response.bytes_stream().map_err(std::io::Error::other);
     let reader = StreamReader::new(reader);
     let reader = GzipDecoder::new(reader);
     let archive = Archive::new(reader);

src/controllers/krate/publish.rs

@@ -67,7 +67,7 @@ const MAX_DESCRIPTION_LENGTH: usize = 1000;
 )]
 pub async fn publish(app: AppState, req: Parts, body: Body) -> AppResult<Json<GoodCrate>> {
     let stream = body.into_data_stream();
-    let stream = stream.map_err(|err| std::io::Error::new(std::io::ErrorKind::Other, err));
+    let stream = stream.map_err(std::io::Error::other);
     let mut reader = StreamReader::new(stream);
 
     // The format of the req.body() of a publish request is as follows:

src/sentry/mod.rs

@@ -113,7 +113,7 @@ mod tests {
             query_string: None,
             env: Default::default(),
         };
-        let err = std::io::Error::new(std::io::ErrorKind::Other, "error");
+        let err = std::io::Error::other("error");
 
         let opts = options(SentryConfig::default());
         let event_req = req.clone();

src/util/errors.rs

@@ -311,7 +311,7 @@ mod tests {
             StatusCode::INTERNAL_SERVER_ERROR
         );
         assert_eq!(
-            BoxedAppError::from(::std::io::Error::new(::std::io::ErrorKind::Other, ""))
+            BoxedAppError::from(::std::io::Error::other(""))
                 .response()
                 .status(),
             StatusCode::INTERNAL_SERVER_ERROR

src/util/io_util.rs

@@ -17,7 +17,7 @@ pub fn read_fill<R: Read + ?Sized>(r: &mut R, mut slice: &mut [u8]) -> io::Resul
     while !slice.is_empty() {
         let n = r.read(slice)?;
         if n == 0 {
-            return Err(io::Error::new(io::ErrorKind::Other, "end of file reached"));
+            return Err(io::Error::other("end of file reached"));
         }
         slice = &mut mem::take(&mut slice)[n..];
     }