Skip to content

Commit c40af56

Browse files
committed
crate/versions: Merge load buttons
1 parent 37725c0 commit c40af56

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed

app/styles/crate/versions.module.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
}
3434
}
3535

36-
.load-more, .loading {
36+
.load-more {
3737
--shadow: 0 1px 3px light-dark(hsla(51, 90%, 42%, .35), #232321);
3838

3939
/* TODO: move to shared */

app/templates/crate/versions.hbs

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -26,20 +26,19 @@
2626
</li>
2727
{{/each}}
2828
</ul>
29-
{{#if this.loadMoreTask.isRunning}}
30-
<div local-class="loading">
31-
<button type="button" data-test-id="loading" disabled={{this.loadMoreTask.isRunning}}
32-
{{on "click" (perform this.loadMoreTask)}}
33-
>
34-
Loading...<LoadingSpinner local-class="loading-spinner" />
35-
</button>
36-
</div>
37-
{{else if this.next_page}}
29+
{{#if (or this.loadMoreTask.isRunning this.next_page)}}
3830
<div local-class="load-more">
39-
<button type="button" data-test-id="load-more" disabled={{this.loadMoreTask.isRunning}}
31+
<button
32+
type="button"
33+
data-test-id={{if this.loadMoreTask.isRunning "loading" "load-more"}}
34+
disabled={{this.loadMoreTask.isRunning}}
4035
{{on "click" (perform this.loadMoreTask)}}
4136
>
42-
Load More
37+
{{#if this.loadMoreTask.isRunning}}
38+
Loading...<LoadingSpinner local-class="loading-spinner" />
39+
{{else}}
40+
Load More
41+
{{/if}}
4342
</button>
4443
</div>
4544
{{/if}}

0 commit comments

Comments
 (0)