VersionList::Row: Only show the actions menu to the privileged user

Author: eth3lbert

app/components/version-list/row.hbs

@@ -117,18 +117,20 @@
     {{/if}}
   </div>
 
-  <Dropdown local-class="dropdown" data-test-actions-menu as |dd|>
-    <dd.Trigger @hideArrow={{true}} local-class="trigger" data-test-actions-toggle>
-      {{svg-jar "ellipsis-circle" local-class="icon"}}
-      <span class="sr-only">Actions</span>
-    </dd.Trigger>
+  <PrivilegedAction @userAuthorised={{this.isOwner}}>
+    <Dropdown local-class="dropdown" data-test-actions-menu as |dd|>
+      <dd.Trigger @hideArrow={{true}} local-class="trigger" data-test-actions-toggle>
+        {{svg-jar "ellipsis-circle" local-class="icon"}}
+        <span class="sr-only">Actions</span>
+      </dd.Trigger>
 
-    <dd.Menu local-class="menu" as |menu|>
-      <menu.Item>
-        <PrivilegedAction @userAuthorised={{this.isOwner}}>
-          <YankButton @version={{@version}} class="button-reset" local-class="menu-button" />
-        </PrivilegedAction>
-      </menu.Item>
-    </dd.Menu>
-  </Dropdown>
+      <dd.Menu local-class="menu" as |menu|>
+        <menu.Item>
+          <PrivilegedAction @userAuthorised={{this.isOwner}}>
+            <YankButton @version={{@version}} class="button-reset" local-class="menu-button" />
+          </PrivilegedAction>
+        </menu.Item>
+      </dd.Menu>
+    </Dropdown>
+  </PrivilegedAction>
 </div>

e2e/acceptance/sudo.spec.ts

@@ -36,6 +36,8 @@ test.describe('Acceptance | sudo', { tag: '@acceptance' }, () => {
     await expect(page.locator('[data-test-disable-admin-actions]')).toHaveCount(0);
     await expect(page.locator('[data-test-enable-admin-actions]')).toHaveCount(0);
 
+    // Assert that there's no dropdown menu toggle, disabled, enabled, or in any state.
+    await expect(page.locator('[data-test-actions-toggle]')).toHaveCount(0);
     // Assert that there's no yank button, disabled, enabled, or in any state.
     await expect(page.locator('[data-test-version-yank-button="0.1.0"]')).toHaveCount(0);
   });
@@ -52,17 +54,14 @@ test.describe('Acceptance | sudo', { tag: '@acceptance' }, () => {
     await expect(page.locator('[data-test-disable-admin-actions]')).toHaveCount(0);
     await expect(page.locator('[data-test-enable-admin-actions]')).toBeVisible();
 
-    await page.locator('[data-test-actions-toggle]').click();
-
     // Test that the fieldset is present and disabled.
-    await expect(page.locator('[data-test-placeholder-fieldset]')).toBeVisible();
+    await expect(page.locator('[data-test-placeholder-fieldset]').first()).toBeVisible();
     // NOTE: `toBeDisabled()` is not working as expected because the element is not a form control element.
     // Ref: https://github.com/microsoft/playwright/issues/13583#issuecomment-1101704985
-    await expect(page.locator('[data-test-placeholder-fieldset]')).toHaveAttribute('disabled', 'disabled');
+    await expect(page.locator('[data-test-placeholder-fieldset]').first()).toHaveAttribute('disabled', 'disabled');
 
-    // From the perspective of the actual button, it isn't disabled, even though
-    // the fieldset effectively makes it unclickable.
-    await expect(page.locator('[data-test-version-yank-button="0.1.0"]')).toBeVisible();
+    await expect(page.locator('[data-test-actions-toggle]')).toBeDisabled();
+    await expect(page.locator('[data-test-version-yank-button="0.1.0"]')).toBeHidden();
   });
 
   test('admin user can enter sudo mode', async ({ page, msw }) => {