crate/settings: Fix notification when adding team owner (#9801)

Author: Turbo87

app/controllers/crate/settings.js

@@ -14,7 +14,12 @@ export default class CrateSettingsController extends Controller {
 
     try {
       await this.crate.inviteOwner(username);
-      this.notifications.success(`An invite has been sent to ${username}`);
+      if (username.includes(':')) {
+        this.notifications.success(`Team ${username} was added as a crate owner`);
+        this.crate.owner_team.reload();
+      } else {
+        this.notifications.success(`An invite has been sent to ${username}`);
+      }
     } catch (error) {
       let detail = error.errors?.[0]?.detail;
       if (detail && !detail.startsWith('{')) {

e2e/acceptance/settings/add-owner.spec.ts

@@ -1,4 +1,4 @@
-import { test, expect } from '@/e2e/helper';
+import { expect, test } from '@/e2e/helper';
 
 test.describe('Acceptance | Settings | Add Owner', { tag: '@acceptance' }, () => {
   test.beforeEach(async ({ mirage }) => {
@@ -52,4 +52,21 @@ test.describe('Acceptance | Settings | Add Owner', { tag: '@acceptance' }, () =>
     await expect(page.locator('[data-test-owners] [data-test-owner-team]')).toHaveCount(2);
     await expect(page.locator('[data-test-owners] [data-test-owner-user]')).toHaveCount(2);
   });
+
+  test('add a team owner', async ({ page, mirage }) => {
+    await mirage.addHook(server => {
+      server.create('user', { name: 'iain8' });
+      server.create('team', { org: 'rust-lang', name: 'crates-io' });
+    });
+
+    await page.goto('/crates/nanomsg/settings');
+    await page.fill('input[name="username"]', 'github:rust-lang:crates-io');
+    await page.click('[data-test-save-button]');
+
+    await expect(page.locator('[data-test-notification-message="success"]')).toHaveText(
+      'Team github:rust-lang:crates-io was added as a crate owner',
+    );
+    await expect(page.locator('[data-test-owners] [data-test-owner-team]')).toHaveCount(3);
+    await expect(page.locator('[data-test-owners] [data-test-owner-user]')).toHaveCount(2);
+  });
 });

tests/acceptance/settings/add-owner-test.js

@@ -61,4 +61,21 @@ module('Acceptance | Settings | Add Owner', function (hooks) {
     assert.dom('[data-test-owners] [data-test-owner-team]').exists({ count: 2 });
     assert.dom('[data-test-owners] [data-test-owner-user]').exists({ count: 2 });
   });
+
+  test('add a team owner', async function (assert) {
+    prepare(this);
+
+    this.server.create('user', { name: 'iain8' });
+    this.server.create('team', { org: 'rust-lang', name: 'crates-io' });
+
+    await visit('/crates/nanomsg/settings');
+    await fillIn('input[name="username"]', 'github:rust-lang:crates-io');
+    await click('[data-test-save-button]');
+
+    assert
+      .dom('[data-test-notification-message="success"]')
+      .hasText('Team github:rust-lang:crates-io was added as a crate owner');
+    assert.dom('[data-test-owners] [data-test-owner-team]').exists({ count: 3 });
+    assert.dom('[data-test-owners] [data-test-owner-user]').exists({ count: 2 });
+  });
 });