AccessToken: Implement FromStr trait and update parsing usages

All of our users at this point have `&str` anyway, so we might as well operate on strings.

Author: Turbo87

crates/crates_io_trustpub/src/access_token.rs

@@ -2,6 +2,7 @@ use rand::distr::{Alphanumeric, SampleString};
 use secrecy::{ExposeSecret, SecretString};
 use sha2::digest::Output;
 use sha2::{Digest, Sha256};
+use std::str::FromStr;
 
 /// A temporary access token used to publish crates to crates.io using
 /// the "Trusted Publishing" feature.
@@ -77,6 +78,17 @@ impl AccessToken {
     }
 }
 
+impl FromStr for AccessToken {
+    type Err = AccessTokenError;
+
+    /// Parse a string into an access token.
+    ///
+    /// This is equivalent to `AccessToken::from_byte_str`.
+    fn from_str(s: &str) -> Result<Self, Self::Err> {
+        Self::from_byte_str(s.as_bytes())
+    }
+}
+
 /// The error type for parsing access tokens.
 #[derive(Debug, Clone, PartialEq, Eq)]
 pub enum AccessTokenError {

src/controllers/krate/publish.rs

@@ -155,7 +155,7 @@ pub async fn publish(app: AppState, req: Parts, body: Body) -> AppResult<Json<Go
                 return None;
             }
 
-            Some(AccessToken::from_byte_str(token.as_bytes()).map_err(|_| {
+            Some(token.parse::<AccessToken>().map_err(|_| {
                 let message = "Invalid `Authorization` header: Failed to parse token";
                 custom(StatusCode::UNAUTHORIZED, message)
             }))

src/controllers/trustpub/tokens/revoke/mod.rs

@@ -24,7 +24,7 @@ mod tests;
 )]
 pub async fn revoke_trustpub_token(app: AppState, auth: AuthHeader) -> AppResult<StatusCode> {
     let token = auth.token().expose_secret();
-    let Ok(token) = AccessToken::from_byte_str(token.as_bytes()) else {
+    let Ok(token) = token.parse::<AccessToken>() else {
         let message = "Invalid `Authorization` header: Failed to parse token";
         return Err(custom(StatusCode::UNAUTHORIZED, message));
     };