Skip to content

Commit e20b903

Browse files
eth3lberteth3lbert
committed
mirage: Reword for consistency
1 parent bb9dc89 commit e20b903

File tree

9 files changed

+22
-22
lines changed

9 files changed

+22
-22
lines changed

‎mirage/route-handlers/crates.js‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -167,12 +167,12 @@ export function register(server) {
167167
return resp;
168168
});
169169

170-
server.get('/api/v1/crates/:name/:version_num/authors', (schema, request) => {
170+
server.get('/api/v1/crates/:name/:version/authors', (schema, request) => {
171171
let { name } = request.params;
172172
let crate = schema.crates.findBy({ name });
173173
if (!crate) return notFound();
174174

175-
let num = request.params.version_num;
175+
let num = request.params.version;
176176
let version = schema.versions.findBy({ crateId: crate.id, num });
177177
if (!version)
178178
return new Response(
@@ -184,12 +184,12 @@ export function register(server) {
184184
return { meta: { names: [] }, users: [] };
185185
});
186186

187-
server.get('/api/v1/crates/:name/:version_num/dependencies', (schema, request) => {
187+
server.get('/api/v1/crates/:name/:version/dependencies', (schema, request) => {
188188
let { name } = request.params;
189189
let crate = schema.crates.findBy({ name });
190190
if (!crate) return notFound();
191191

192-
let num = request.params.version_num;
192+
let num = request.params.version;
193193
let version = schema.versions.findBy({ crateId: crate.id, num });
194194
if (!version)
195195
return new Response(
@@ -201,12 +201,12 @@ export function register(server) {
201201
return schema.dependencies.where({ versionId: version.id });
202202
});
203203

204-
server.get('/api/v1/crates/:name/:version_num/downloads', function (schema, request) {
204+
server.get('/api/v1/crates/:name/:version/downloads', function (schema, request) {
205205
let { name } = request.params;
206206
let crate = schema.crates.findBy({ name });
207207
if (!crate) return notFound();
208208

209-
let num = request.params.version_num;
209+
let num = request.params.version;
210210
let version = schema.versions.findBy({ crateId: crate.id, num });
211211
if (!version)
212212
return new Response(
@@ -377,13 +377,13 @@ export function register(server) {
377377
return new Response(403, {}, { errors: [{ detail: 'must be logged in to perform that action' }] });
378378
}
379379

380-
const { name, version: versionNum } = request.params;
380+
const { name, version: num } = request.params;
381381
const crate = schema.crates.findBy({ name });
382382
if (!crate) {
383383
return notFound();
384384
}
385385

386-
const version = schema.versions.findBy({ crateId: crate.id, num: versionNum });
386+
const version = schema.versions.findBy({ crateId: crate.id, num });
387387
if (!version) {
388388
return notFound();
389389
}
@@ -403,13 +403,13 @@ export function register(server) {
403403
return new Response(403, {}, { errors: [{ detail: 'must be logged in to perform that action' }] });
404404
}
405405

406-
const { name, version: versionNum } = request.params;
406+
const { name, version: num } = request.params;
407407
const crate = schema.crates.findBy({ name });
408408
if (!crate) {
409409
return notFound();
410410
}
411411

412-
const version = schema.versions.findBy({ crateId: crate.id, num: versionNum });
412+
const version = schema.versions.findBy({ crateId: crate.id, num });
413413
if (!version) {
414414
return notFound();
415415
}
@@ -425,13 +425,13 @@ export function register(server) {
425425
return new Response(403, {}, { errors: [{ detail: 'must be logged in to perform that action' }] });
426426
}
427427

428-
const { name, version: versionNum } = request.params;
428+
const { name, version: num } = request.params;
429429
const crate = schema.crates.findBy({ name });
430430
if (!crate) {
431431
return notFound();
432432
}
433433

434-
const version = schema.versions.findBy({ crateId: crate.id, num: versionNum });
434+
const version = schema.versions.findBy({ crateId: crate.id, num });
435435
if (!version) {
436436
return notFound();
437437
}
@@ -442,13 +442,13 @@ export function register(server) {
442442
});
443443

444444
server.get('/api/v1/crates/:name/:version/readme', (schema, request) => {
445-
const { name, version: versionNum } = request.params;
445+
const { name, version: num } = request.params;
446446
const crate = schema.crates.findBy({ name });
447447
if (!crate) {
448448
return new Response(403, { 'Content-Type': 'text/html' }, '');
449449
}
450450

451-
const version = schema.versions.findBy({ crateId: crate.id, num: versionNum });
451+
const version = schema.versions.findBy({ crateId: crate.id, num });
452452
if (!version || !version.readme) {
453453
return new Response(403, { 'Content-Type': 'text/html' }, '');
454454
}

‎tests/mirage/crates/versions/authors-test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import fetch from 'fetch';
55
import { setupTest } from '../../../helpers';
66
import setupMirage from '../../../helpers/setup-mirage';
77

8-
module('Mirage | GET /api/v1/crates/:id/:version/authors', function (hooks) {
8+
module('Mirage | GET /api/v1/crates/:name/:version/authors', function (hooks) {
99
setupTest(hooks);
1010
setupMirage(hooks);
1111

‎tests/mirage/crates/versions/dependencies-test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import fetch from 'fetch';
55
import { setupTest } from '../../../helpers';
66
import setupMirage from '../../../helpers/setup-mirage';
77

8-
module('Mirage | GET /api/v1/crates/:id/:version/dependencies', function (hooks) {
8+
module('Mirage | GET /api/v1/crates/:name/:version/dependencies', function (hooks) {
99
setupTest(hooks);
1010
setupMirage(hooks);
1111

‎tests/mirage/crates/versions/downloads-test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import fetch from 'fetch';
55
import { setupTest } from '../../../helpers';
66
import setupMirage from '../../../helpers/setup-mirage';
77

8-
module('Mirage | GET /api/v1/crates/:id/:version/downloads', function (hooks) {
8+
module('Mirage | GET /api/v1/crates/:name/:version/downloads', function (hooks) {
99
setupTest(hooks);
1010
setupMirage(hooks);
1111

‎tests/mirage/crates/versions/list-test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import fetch from 'fetch';
55
import { setupTest } from '../../../helpers';
66
import setupMirage from '../../../helpers/setup-mirage';
77

8-
module('Mirage | GET /api/v1/crates/:id/versions', function (hooks) {
8+
module('Mirage | GET /api/v1/crates/:name/versions', function (hooks) {
99
setupTest(hooks);
1010
setupMirage(hooks);
1111

‎tests/mirage/crates/versions/patch-test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ const UNYANK_BODY = JSON.stringify({
1818
},
1919
});
2020

21-
module('Mirage | PATCH /api/v1/crates/:crate/:version', function (hooks) {
21+
module('Mirage | PATCH /api/v1/crates/:name/:version', function (hooks) {
2222
setupTest(hooks);
2323
setupMirage(hooks);
2424

‎tests/mirage/crates/versions/readme-test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import fetch from 'fetch';
55
import { setupTest } from '../../../helpers';
66
import setupMirage from '../../../helpers/setup-mirage';
77

8-
module('Mirage | GET /api/v1/crates/:id/:version/readme', function (hooks) {
8+
module('Mirage | GET /api/v1/crates/:name/:version/readme', function (hooks) {
99
setupTest(hooks);
1010
setupMirage(hooks);
1111

‎tests/mirage/crates/versions/yank/unyank-test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import fetch from 'fetch';
55
import { setupTest } from '../../../../helpers';
66
import setupMirage from '../../../../helpers/setup-mirage';
77

8-
module('Mirage | PUT /api/v1/crates/:crateId/unyank', function (hooks) {
8+
module('Mirage | PUT /api/v1/crates/:name/unyank', function (hooks) {
99
setupTest(hooks);
1010
setupMirage(hooks);
1111

‎tests/mirage/crates/versions/yank/yank-test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import fetch from 'fetch';
55
import { setupTest } from '../../../../helpers';
66
import setupMirage from '../../../../helpers/setup-mirage';
77

8-
module('Mirage | DELETE /api/v1/crates/:crateId/yank', function (hooks) {
8+
module('Mirage | DELETE /api/v1/crates/:name/yank', function (hooks) {
99
setupTest(hooks);
1010
setupMirage(hooks);
1111

0 commit comments

Comments
 (0)