Skip to content

Commit e7a1f75

Browse files
committed
models/crate: Remove obsolete getter and functions
These sorted version computations are no longer needed, we fetch the sorted data from the backend now.
1 parent 1f12bc0 commit e7a1f75

File tree

1 file changed

+0
-36
lines changed

1 file changed

+0
-36
lines changed

app/models/crate.js

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -45,20 +45,6 @@ export default class Crate extends Model {
4545
@hasMany('category', { async: true, inverse: null }) categories;
4646
@hasMany('dependency', { async: true, inverse: null }) reverse_dependencies;
4747

48-
@cached get versionIdsBySemver() {
49-
let versions = this.loadedVersionsById.values();
50-
return Array.from(versions)
51-
.sort(compareVersionBySemver)
52-
.map(v => v.id);
53-
}
54-
55-
@cached get versionIdsByDate() {
56-
let versions = this.loadedVersionsById.values();
57-
return Array.from(versions)
58-
.sort(compareVersionByDate)
59-
.map(v => v.id);
60-
}
61-
6248
/** @return {Map<number, import("../models/version").default>} */
6349
@cached
6450
get loadedVersionsById() {
@@ -138,25 +124,3 @@ export default class Crate extends Model {
138124
return (await fut) ?? [];
139125
});
140126
}
141-
142-
function compareVersionBySemver(a, b) {
143-
let aSemver = a.semver;
144-
let bSemver = b.semver;
145-
146-
if (aSemver === bSemver) {
147-
return b.created_at - a.created_at;
148-
} else if (aSemver === null) {
149-
return 1;
150-
} else if (bSemver === null) {
151-
return -1;
152-
} else {
153-
return bSemver.compare(aSemver);
154-
}
155-
}
156-
157-
function compareVersionByDate(a, b) {
158-
let bDate = b.created_at.getTime();
159-
let aDate = a.created_at.getTime();
160-
161-
return bDate === aDate ? parseInt(b.id) - parseInt(a.id) : bDate - aDate;
162-
}

0 commit comments

Comments
 (0)