Skip to content

Commit f5acbaf

Browse files
committed
Update rss dependency
This update fixes the escaping of `]]>` in `CDATA`, which means we can remove our current workaround :)
1 parent df815d7 commit f5acbaf

File tree

4 files changed

+5
-13
lines changed

4 files changed

+5
-13
lines changed

Cargo.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ postgres-native-tls = "=0.5.0"
101101
prometheus = { version = "=0.13.4", default-features = false }
102102
rand = "=0.8.5"
103103
reqwest = { version = "=0.12.9", features = ["gzip", "json"] }
104-
rss = { version = "=2.0.10", default-features = false, features = ["atom"] }
104+
rss = { version = "=2.0.11", default-features = false, features = ["atom"] }
105105
secrecy = "=0.10.3"
106106
semver = { version = "=1.0.23", features = ["serde"] }
107107
sentry = { version = "=0.34.0", features = ["tracing", "tower", "tower-axum-matched-path", "tower-http"] }

src/worker/jobs/rss/sync_crates_feed.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,6 @@ impl NewCrate {
125125
permalink: true,
126126
};
127127

128-
let description = self
129-
.description
130-
.map(|d| d.replace("]]>", "]]]]><![CDATA[>"));
131-
132128
let name_extension = rss::extension::Extension {
133129
name: "crates:name".into(),
134130
value: Some(self.name),
@@ -144,7 +140,7 @@ impl NewCrate {
144140
guid: Some(guid),
145141
title: Some(title),
146142
link: Some(link),
147-
description,
143+
description: self.description,
148144
pub_date: Some(pub_date),
149145
extensions,
150146
..Default::default()

src/worker/jobs/rss/sync_updates_feed.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,6 @@ impl VersionUpdate {
132132
permalink: true,
133133
};
134134

135-
let description = self
136-
.description
137-
.map(|d| d.replace("]]>", "]]]]><![CDATA[>"));
138-
139135
let name_extension = rss::extension::Extension {
140136
name: "crates:name".into(),
141137
value: Some(self.name),
@@ -160,7 +156,7 @@ impl VersionUpdate {
160156
guid: Some(guid),
161157
title: Some(title),
162158
link: Some(link),
163-
description,
159+
description: self.description,
164160
pub_date: Some(pub_date),
165161
extensions,
166162
..Default::default()

0 commit comments

Comments
 (0)