Skip to content

Commit ff5c036

Browse files
committed
app!: Drop first version hint support from the versions list
1 parent 07bb7af commit ff5c036

File tree

5 files changed

+1
-14
lines changed

5 files changed

+1
-14
lines changed

app/components/version-list/row.hbs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
{{svg-jar "trash"}}
1515
{{else if @version.invalidSemver}}
1616
?
17-
{{else if @version.isFirst}}
18-
{{svg-jar "star"}}
1917
{{else}}
2018
{{@version.releaseTrack}}
2119
{{/if}}

app/components/version-list/row.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ export default class VersionRow extends Component {
1919
if (version.invalidSemver) {
2020
return `Failed to parse version ${version.num}`;
2121
}
22-
if (version.isFirst) {
23-
return 'This is the first version that was released';
24-
}
2522

2623
let { releaseTrack } = version;
2724

app/models/crate.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,6 @@ export default class Crate extends Model {
5757
.map(v => v.id);
5858
}
5959

60-
@cached get firstVersionId() {
61-
return this.versionIdsByDate.at(-1);
62-
}
63-
6460
@cached get versionsObj() {
6561
let { last } = this.loadVersionsTask;
6662
assert('`loadVersionsTask.perform()` must be called before calling `versionsObj`', last != null);

app/models/version.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,6 @@ export default class Version extends Model {
7272
return Date.now() - this.created_at.getTime() < EIGHT_DAYS;
7373
}
7474

75-
@cached get isFirst() {
76-
return this.id === this.crate?.firstVersionId;
77-
}
78-
7975
get semver() {
8076
return semverParse(this.num, { loose: true });
8177
}

tests/components/version-list-row-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ module('Component | VersionList::Row', function (hooks) {
2323
this.secondVersion = versions.find(it => it.num === '0.3.0-alpha.01');
2424

2525
await render(hbs`<VersionList::Row @version={{this.firstVersion}} />`);
26-
assert.dom('[data-test-release-track] svg').exists();
26+
assert.dom('[data-test-release-track]').hasText('0.4');
2727
assert.dom('[data-test-release-track-link]').hasText('0.4.0-alpha.01');
2828

2929
await render(hbs`<VersionList::Row @version={{this.secondVersion}} />`);

0 commit comments

Comments
 (0)