Keywords are sometimes missing

[pentamassiv]

Current Behavior

When I search for a crate, e.g. enigo and click on its name, the description of the crate and other metadata gets displayed. However the keywords are missing. If I open the crate details in a new tab instead, the keywords get displayed.

Missing keywords:

Correctly displayed keywords:

Expected Behavior

The keywords of a crate should always get displayed, no matter if it gets opened in a new tab or in the current tab

Steps To Reproduce

• Open crates.io
• Search for "enigo" (anything will do)
• Right click on the result and open in a new tab
• Left click on the result and open it in the current tab
• Compare the content of the tabs

Environment

• Browser: Librewolf 135.0.1-1
• OS: Arch Linux

Anything else?

When the keywords are missing, the "Toggle Reader view" is available. If the keywords are present, the toggle is missing. That's not important to me, but I thought that's curious too

[Turbo87]

@eth3lbert could this be related to your latest data loading changes?

[eth3lbert]

@eth3lbert could this be related to your latest data loading changes?

I think this happens because we're using peekRecord() in routes which was introduced in #10369. Search crates don't have keywords, and peekRecord() gets the record from the store instead of asking the server, so the keyword ends up null.

[eth3lbert]

A naive solution is to always use queryRecord(). A slightly better approach would be to check the peeked record. If the keywords is null, then call queryRecord(). This is reasonable since we have the create request with default includes.

[pentamassiv]

Thank you for your quick response.

Is this already deployed? I am asking, because there is no changed behavior for me. The keywords are still missing if I don't open the crate in a new tab.

[Turbo87]

nope, only merged, not deployed yet