Replace ember-tooltips with floating-ui
#10513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
A-frontend 🐹
C-internal 🔧
Member
|
@Turbo87 Some tests failed. |
Member
Author
should be fixed now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://floating-ui.com is a low-level library to implement e.g. tooltips. This PR replaces the unmaintained
ember-tooltipsaddon with a customTooltipcomponent based onfloating-uithat works roughly similar. This should hopefully then unblock the@ember/stringupdate in #10354.Before
After
yes, we lost the arrow, but does that really matter? 😅
floating-ui does have an "arrow middleware", but I couldn't make it work properly in combination with
flip(). since it would require more complexity for IMHO little gain I think it's fine to ship this without arrows.