Skip to content

capitalize first sentence of crate delete mail #10522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2025
Merged

capitalize first sentence of crate delete mail #10522

merged 2 commits into from
Feb 7, 2025

Conversation

@Uriopass
Copy link
Contributor

@Uriopass Uriopass commented Feb 6, 2025

Tiny thing, kind of bugged me when I received the mail.

Turbo87
Turbo87 reviewed Feb 6, 2025
View reviewed changes
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a native english speaker, but since the email begins with "Hi {username}," wouldn't this still be part of the same sentence and thus not have captialization? 😅

@Uriopass
Copy link
Contributor Author

Uriopass commented Feb 6, 2025

It's a very wide convention to capitalize the first sentence after the greeting, although not completely unanimous it's the majority.
See: https://english.stackexchange.com/questions/11906/should-i-capitalize-the-starting-sentence-after-a-greeting-that-ends-in-a-comma

However, as far as I can tell, there is no good reason to oppose conventional style in this case. I would therefore recommend that you stick with the tried-and-true style of using a capital letter to start the letter proper:

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-backend ⚙️ labels Feb 7, 2025
Turbo87
Turbo87 approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks!

I've rebased this PR and fixed the broken snapshot files in the test suite.

@Turbo87 Turbo87 enabled auto-merge February 7, 2025 09:16
@Turbo87 Turbo87 merged commit 2b757c3 into rust-lang:main Feb 7, 2025
10 checks passed
@Uriopass
Copy link
Contributor Author

Uriopass commented Feb 7, 2025

Thanks! I should have fixed the snapshot myself. Will do if there's a next time :)

@Uriopass Uriopass deleted the patch-1 branch February 7, 2025 09:49
@Turbo87
Copy link
Member

Turbo87 commented Feb 7, 2025

Feel free to take a look at the other email templates. I have a feeling that this might not be the only one that used this pattern 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees

No one assigned

Labels

A-backend ⚙️ C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Uriopass @Turbo87