Adjust loading spinner color #10806
Merged
Adjust loading spinner color #10806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth3lbert
added
C-enhancement ✨
Member
|
would it be possible to use the text color instead so that we don't have to override anything? |
Turbo87
reviewed
Mar 11, 2025
Contributor
Author
Yeah, I've thought of this before. However, for the background, it would be great if |
eth3lbert
force-pushed
the
indicator-color
branch
from
fac5ac1 to
60e4ced
Compare
Contributor
Author
|
Updated to use the |
eth3lbert
force-pushed
the
indicator-color
branch
from
60e4ced to
935c420
Compare
Turbo87
reviewed
Mar 14, 2025
Most spinners are either outside the button or inside a button whose background changes accordingly with the color mode. However, there are some buttons whose background color doesn't change with the color mode. For those buttons that don't follow the color mode, we add a light theme for them.
eth3lbert
force-pushed
the
indicator-color
branch
from
935c420 to
0e41e1a
Compare
Turbo87
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the spinner color to follow the color mode, and ensures certain buttons' loading spinners remain dark, especially those with backgrounds that do not follow the color mode.
Before:
After:
Before:
After:
