Skip to content

Adjust loading spinner color #10806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2025
Merged

Adjust loading spinner color #10806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e688e9
loading-spinner: Adjust `--spinner-color` and `--spinner-bg-color` fo…
eth3lbert Mar 11, 2025
0e41e1a
loading-spinner: Set spinner theme to light for certain buttons
eth3lbert Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/follow-button.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
{{on "click" (perform this.toggleFollowTask)}}
>
{{#if (or this.followStateTask.isRunning this.toggleFollowTask.isRunning)}}
<LoadingSpinner data-test-spinner />
<LoadingSpinner @theme="light" data-test-spinner />
{{else}}
{{#if this.following}}
Unfollow
Expand Down
2 changes: 1 addition & 1 deletion app/components/loading-spinner.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div
local-class="spinner"
local-class="spinner {{if (eq @theme 'light') 'light'}}"
...attributes
>
<span local-class="message">Loading…</span>
Expand Down
8 changes: 6 additions & 2 deletions app/components/loading-spinner.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
.spinner {
--spinner-color: black;
--spinner-bg-color: rgba(0, 0, 0, .2);
--spinner-color: currentcolor;
--spinner-bg-color: var(--gray-border);
--spinner-size: 16px;

display: inline-block;
height: var(--spinner-size);
width: var(--spinner-size);

&.light {
--spinner-bg-color: rgba(0, 0, 0, .2);
}

&:after {
content: " ";
display: block;
Expand Down
2 changes: 1 addition & 1 deletion app/templates/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
>
Try Again
{{#if this.dataTask.isRunning}}
<LoadingSpinner local-class="spinner" data-test-spinner />
<LoadingSpinner @theme="light" local-class="spinner" data-test-spinner />
{{/if}}
</button>
{{else}}
Expand Down
2 changes: 1 addition & 1 deletion app/templates/settings/tokens/new.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@
Generate Token

{{#if this.saveTokenTask.isRunning}}
<LoadingSpinner local-class="spinner" data-test-spinner />
<LoadingSpinner @theme="light" local-class="spinner" data-test-spinner />
{{/if}}
</button>

Expand Down
Loading