Skip to content

trustpub: Improve config creation form #11509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2025
Merged

trustpub: Improve config creation form #11509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8ab92c
trustpub: Add examples to workflow filename help text
Turbo87 Jul 3, 2025
510069f
trustpub: Improve form layout and styling for trusted publisher creation
Turbo87 Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/styles/crate/settings/new-trusted-publisher.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
.form {
max-width: 600px;
margin: var(--space-m) auto;
}

.form-group, .buttons {
margin: var(--space-m) 0;
}

.publisher-select {
max-width: 440px;
max-width: 600px;
width: 100%;
padding-right: var(--space-m);
background-image: url("/assets/dropdown.svg");
Expand All @@ -19,7 +24,7 @@
}

.input {
max-width: 440px;
max-width: 600px;
width: 100%;
}

Expand Down
6 changes: 3 additions & 3 deletions app/templates/crate/settings/new-trusted-publisher.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<h2>Add a new Trusted Publisher</h2>
<form local-class="form" {{on "submit" (prevent-default (perform this.saveConfigTask))}}>
<h2>Add a new Trusted Publisher</h2>

<form {{on "submit" (prevent-default (perform this.saveConfigTask))}}>
<div local-class="form-group">
{{#let (unique-id) as |id|}}
<label for={{id}} class="form-group-name">Publisher</label>
Expand Down Expand Up @@ -106,7 +106,7 @@
</div>
{{else}}
<div local-class="note">
The filename of the publishing workflow. This file should be present in the <code>.github/workflows/</code> directory of the repository configured above.
The filename of the publishing workflow. This file should be present in the <code>.github/workflows/</code> directory of the repository configured above. For example: <code>release.yml</code> or <code>publish.yml</code>.
</div>
{{/if}}
{{/let}}
Expand Down
Loading