don't overwrite release information on failed builds

Author: syphar

.sqlx/query-e3216009b040994f88958082b518e2bbdb89147a2ef8b29e85bb9695c4bc8374.json

@@ -581,7 +581,32 @@ impl RustwideBuilder {
                     None
                 };
 
-                let has_examples = build.host_source_dir().join("examples").is_dir();
+                let mut async_conn = self.runtime.block_on(self.db.get_async())?;
+
+                self.runtime.block_on(finish_build(
+                    &mut async_conn,
+                    build_id,
+                    &res.result.rustc_version,
+                    &res.result.docsrs_version,
+                    if res.result.successful {
+                        BuildStatus::Success
+                    } else {
+                        BuildStatus::Failure
+                    },
+                    documentation_size,
+                    None,
+                ))?;
+
+                {
+                    let _span = info_span!("store_build_logs").entered();
+                    let build_log_path = format!("build-logs/{build_id}/{default_target}.txt");
+                    self.storage.store_one(build_log_path, res.build_log)?;
+                    for (target, log) in target_build_logs {
+                        let build_log_path = format!("build-logs/{build_id}/{target}.txt");
+                        self.storage.store_one(build_log_path, log)?;
+                    }
+                }
+
                 if res.result.successful {
                     self.metrics.successful_builds.inc();
                 } else if res.cargo_metadata.root().is_library() {
@@ -611,8 +636,26 @@ impl RustwideBuilder {
                 let cargo_metadata = res.cargo_metadata.root();
                 let repository = self.get_repo(cargo_metadata)?;
 
-                let mut async_conn = self.runtime.block_on(self.db.get_async())?;
+                // when we have an unsuccessful build, but the release was already successfullly
+                // built in the past, don't touch the release record so the docs stay intact.
+                // This mainly happens with manually triggered or automated rebuilds.
+                // The `release_build_status` table is already updated with the information from
+                // the current build via `finish_build`.
+                let current_release_build_status = self.runtime.block_on(sqlx::query_scalar!(
+                    r#"
+                    SELECT build_status AS "build_status: BuildStatus"
+                    FROM release_build_status
+                    WHERE rid = $1
+                    "#,
+                    release_id.0,
+                ).fetch_optional(&mut *async_conn))?;
+
+                if !res.result.successful && current_release_build_status == Some(BuildStatus::Success) {
+                    info!("build was unsuccessful, but the release was already successfully built in the past. Skipping release record update.");
+                    return Ok(false);
+                }
 
+                let has_examples = build.host_source_dir().join("examples").is_dir();
                 self.runtime.block_on(finish_release(
                     &mut async_conn,
                     crate_id,
@@ -639,31 +682,6 @@ impl RustwideBuilder {
                     ))?;
                 }
 
-                let build_status = if res.result.successful {
-                    BuildStatus::Success
-                } else {
-                    BuildStatus::Failure
-                };
-                self.runtime.block_on(finish_build(
-                    &mut async_conn,
-                    build_id,
-                    &res.result.rustc_version,
-                    &res.result.docsrs_version,
-                    build_status,
-                    documentation_size,
-                    None,
-                ))?;
-
-                {
-                    let _span = info_span!("store_build_logs").entered();
-                    let build_log_path = format!("build-logs/{build_id}/{default_target}.txt");
-                    self.storage.store_one(build_log_path, res.build_log)?;
-                    for (target, log) in target_build_logs {
-                        let build_log_path = format!("build-logs/{build_id}/{target}.txt");
-                        self.storage.store_one(build_log_path, log)?;
-                    }
-                }
-
                 // Some crates.io crate data is mutable, so we proactively update it during a release
                 if !is_local {
                     match self