Skip to content

Commit 1fd6762

Browse files
committed
upgrade base64
1 parent 0896adf commit 1fd6762

File tree

5 files changed

+14
-17
lines changed

5 files changed

+14
-17
lines changed

Cargo.lock

Lines changed: 1 addition & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ zstd = "0.12.0"
5656
hostname = "0.3.1"
5757
path-slash = "0.2.0"
5858
once_cell = { version = "1.4.0", features = ["parking_lot"] }
59-
base64 = "0.20"
59+
base64 = "0.21"
6060
strum = { version = "0.24.0", features = ["derive"] }
6161
lol_html = "0.3"
6262
font-awesome-as-a-crate = { path = "crates/font-awesome-as-a-crate" }

src/test/fakes.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ use crate::index::api::{CrateData, CrateOwner, ReleaseData};
66
use crate::storage::{rustdoc_archive_path, source_archive_path, Storage};
77
use crate::utils::{Dependency, MetadataPackage, Target};
88
use anyhow::Context;
9+
use base64::{engine::general_purpose::STANDARD as b64, Engine};
910
use chrono::{DateTime, Utc};
1011
use postgres::Client;
1112
use std::collections::{HashMap, HashSet};
@@ -439,7 +440,7 @@ impl FakeGithubStats {
439440
let existing_count: i64 = conn
440441
.query_one("SELECT COUNT(*) FROM repositories;", &[])?
441442
.get(0);
442-
let host_id = base64::encode(format!("FAKE ID {existing_count}"));
443+
let host_id = b64.encode(format!("FAKE ID {existing_count}"));
443444

444445
let data = conn.query_one(
445446
"INSERT INTO repositories (host, host_id, name, description, last_commit, stars, forks, issues, updated_at)

src/web/csp.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ use crate::config::Config;
22
use axum::{
33
http::Request as AxumHttpRequest, middleware::Next, response::Response as AxumResponse,
44
};
5+
use base64::{engine::general_purpose::STANDARD as b64, Engine};
56
use std::{
67
fmt::Write,
78
sync::{
@@ -23,7 +24,7 @@ impl Csp {
2324
getrandom::getrandom(&mut random).expect("failed to generate a nonce");
2425

2526
Self {
26-
nonce: base64::encode(random),
27+
nonce: b64.encode(random),
2728
suppress: AtomicBool::new(false),
2829
}
2930
}

src/web/releases.rs

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ use axum::{
1818
extract::{Extension, Path, Query},
1919
response::{IntoResponse, Response as AxumResponse},
2020
};
21+
use base64::{engine::general_purpose::STANDARD as b64, Engine};
2122
use chrono::{DateTime, NaiveDate, Utc};
2223
use postgres::Client;
2324
use serde::{Deserialize, Serialize};
@@ -560,7 +561,7 @@ pub(crate) async fn search_handler(
560561
}
561562

562563
let search_result = if let Some(paginate) = params.get("paginate") {
563-
let decoded = base64::decode(paginate.as_bytes()).map_err(|e| {
564+
let decoded = b64.decode(paginate.as_bytes()).map_err(|e| {
564565
warn!(
565566
"error when decoding pagination base64 string \"{}\": {:?}",
566567
paginate, e
@@ -609,10 +610,10 @@ pub(crate) async fn search_handler(
609610
search_query: Some(executed_query),
610611
next_page_link: search_result
611612
.next_page
612-
.map(|params| format!("/releases/search?paginate={}", base64::encode(params))),
613+
.map(|params| format!("/releases/search?paginate={}", b64.encode(params))),
613614
previous_page_link: search_result
614615
.prev_page
615-
.map(|params| format!("/releases/search?paginate={}", base64::encode(params))),
616+
.map(|params| format!("/releases/search?paginate={}", b64.encode(params))),
616617
..Default::default()
617618
}
618619
.into_response())
@@ -932,14 +933,14 @@ mod tests {
932933
other_search_links[0],
933934
format!(
934935
"/releases/search?paginate={}",
935-
base64::encode("?and=the&parameters=for&the=previouspage"),
936+
b64.encode("?and=the&parameters=for&the=previouspage"),
936937
)
937938
);
938939
assert_eq!(
939940
other_search_links[1],
940941
format!(
941942
"/releases/search?paginate={}",
942-
base64::encode("?some=parameters&that=cratesio&might=return")
943+
b64.encode("?some=parameters&that=cratesio&might=return")
943944
)
944945
);
945946

@@ -954,7 +955,7 @@ mod tests {
954955
.frontend()
955956
.get(&format!(
956957
"/releases/search?paginate={}",
957-
base64::encode("something_that_doesnt_start_with_?")
958+
b64.encode("something_that_doesnt_start_with_?")
958959
))
959960
.send()?;
960961
assert_eq!(response.status(), StatusCode::NOT_FOUND);
@@ -1016,7 +1017,7 @@ mod tests {
10161017
let links = get_release_links(
10171018
&format!(
10181019
"/releases/search?paginate={}",
1019-
base64::encode("?some=dummy&pagination=parameters")
1020+
b64.encode("?some=dummy&pagination=parameters")
10201021
),
10211022
web,
10221023
)?;

0 commit comments

Comments
 (0)