Skip to content

Commit bc47350

Browse files
Simplify version handling of browser-ui-test
1 parent 8bbaf87 commit bc47350

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

dockerfiles/Dockerfile-gui-tests

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,13 +69,13 @@ WORKDIR /build
6969

7070
RUN mkdir out
7171

72+
COPY ../package.json /build/package.json
73+
7274
# For now, we need to use `--unsafe-perm=true` to go around an issue when npm tries
7375
# to create a new folder. For reference:
7476
# https://github.com/puppeteer/puppeteer/issues/375
7577
#
7678
# We also specify the version in case we need to update it to go around cache limitations.
77-
RUN npm install -g [email protected] --unsafe-perm=true
78-
79-
EXPOSE 3000
79+
RUN npm install -g --unsafe-perm=true /build
8080

8181
CMD ["node", "/build/out/gui-tests/tester.js"]

dockerfiles/run-gui-tests.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,12 @@ fi
3232

3333
. .env
3434

35+
set +e # We disable the "exit right away if command failed" setting.
3536
cargo run -- start-web-server &
3637
SERVER_PID=$!
3738

3839
# status="docker run . -v `pwd`:/build/out:ro gui_tests"
39-
docker compose run gui_tests
40+
docker compose run --rm gui_tests
4041
status=$?
4142
kill $SERVER_PID
4243
exit $status

0 commit comments

Comments
 (0)