Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 22 additions & 0 deletions src/web/crate_details.rs
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ pub(crate) struct CrateDetails {
pub(crate) crate_id: i32,
/// Database id for this release
pub(crate) release_id: i32,
source_size: Option<i64>,
documentation_size: Option<i64>,
}

#[derive(Debug, Clone, PartialEq)]
Expand Down Expand Up @@ -122,6 +124,8 @@ impl CrateDetails {
req_version: Option<ReqVersion>,
prefetched_releases: Vec<Release>,
) -> Result<Option<CrateDetails>, anyhow::Error> {
// FIXME: Since all subqueries from `builds` table have the same conditions, would be
// nice to group them in one subquery instead.
let krate = match sqlx::query!(
r#"SELECT
crates.id AS crate_id,
Expand Down Expand Up @@ -163,6 +167,16 @@ impl CrateDetails {
releases.license,
releases.documentation_url,
releases.default_target,
releases.source_size as "source_size?",
(
SELECT documentation_size
FROM builds
WHERE
builds.rid = releases.id AND
builds.build_status = 'success'
ORDER BY builds.build_finished
DESC LIMIT 1
) as "documentation_size?",
(
-- we're using the rustc version here to set the correct CSS file
-- in the metadata.
Expand Down Expand Up @@ -258,6 +272,8 @@ impl CrateDetails {
items_with_examples: krate.items_with_examples,
crate_id: krate.crate_id,
release_id: krate.release_id,
documentation_size: krate.documentation_size,
source_size: krate.source_size,
};

// get owners
Expand Down Expand Up @@ -442,6 +458,8 @@ struct CrateDetailsPage {
last_successful_build: Option<String>,
rustdoc: Option<String>, // this is description_long in database
csp_nonce: String,
source_size: Option<i64>,
documentation_size: Option<i64>,
}

impl CrateDetailsPage {
Expand Down Expand Up @@ -513,6 +531,8 @@ pub(crate) async fn crate_details_handler(
is_library,
last_successful_build,
rustdoc,
source_size,
documentation_size,
..
} = details;

Expand All @@ -538,6 +558,8 @@ pub(crate) async fn crate_details_handler(
last_successful_build,
rustdoc,
csp_nonce: String::new(),
source_size,
documentation_size,
}
.into_response();
res.extensions_mut()
Expand Down
13 changes: 12 additions & 1 deletion templates/crate/details.html
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,19 @@
{%- endif -%}
</li>
{%- endif -%}
<li class="pure-menu-heading">Links</li>
{%- if let Some(source_size) = source_size -%}
<li class="pure-menu-heading">Size</li>
<li class="pure-menu-item">
<span class="documented-info">Source code size: {{(*source_size)|filesizeformat}}</span>
</li>
{%- if let Some(doc_size) = documentation_size -%}
<li class="pure-menu-item">
<span class="documented-info">Documentation size: {{(*doc_size)|filesizeformat}}</span>
</li>
{%- endif -%}
{%- endif -%}

<li class="pure-menu-heading">Links</li>
{# If the crate has a homepage, show it #}
{%- if let Some(homepage_url) = homepage_url -%}
<li class="pure-menu-item">
Expand Down
Loading