migrate most tests to async, drop old testserver & blocking reqwests #2671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
syphar
force-pushed
the
better-fake-test
branch
from
cec7833 to
26cbc06
Compare
This comment was marked as outdated.
This comment was marked as outdated.
syphar
force-pushed
the
better-fake-test
branch
from
26cbc06 to
578fb20
Compare
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bigger refactor that was sitting in a branch for some time, so sorry for the size of the change. This migrates most tests to be async tests following the axum test framework, see also #2634 and the axum test example.
This makes is possible that we don't have to run an actual TCP server for each test any more.
There are only a handful of tests missing to migrate, mostly from sync parts of the code.
A second change in there is that I didn't want the web tests to automatically follow redirects any more. So the tests have to be explicit when they expect the response directly, or via a redirect.
The next improvement will be about the the database setup which hopefully make tests execute.