Fix display of long crates name in release list #2734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
changed the title
github-actions
bot
added
the
S-waiting-on-review
GuillaumeGomez
commented
Feb 3, 2025
Member
Author
|
I added a GUI test as well. |
Member
Author
|
Forgot to push so now it's done. 😅 |
Member
|
thanks! When I test, the change looks different than the screenshot? |
Member
|
Member
|
also the gui tests fail |
Member
Author
|
Ah right, might need to update the node version. As for the fix, you need to hover the item to actually see it in action. ;) |
GuillaumeGomez
force-pushed
the
fix-crate-name-display
branch
from
3aed050 to
553e4ba
Compare
syphar
approved these changes
Feb 5, 2025
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2733.
It now looks like this:
Gonna send a GUI test once I added something missing into the framework to make the test simpler.