Skip to content

rustdoc json: check target existance before redirecting to S3 #2837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

rustdoc json: check target existance before redirecting to S3 #2837

merged 1 commit into from
May 28, 2025

Conversation

@syphar
Copy link
Member

@syphar syphar commented May 27, 2025

so we can return a nice 404 instead of the 403 from S3/CloudFront

@syphar syphar requested a review from a team as a code owner May 27, 2025 18:50
@github-actions github-actions bot added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels May 27, 2025
@syphar syphar merged commit d291104 into rust-lang:master May 28, 2025
11 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels May 28, 2025
@syphar syphar deleted the check-target-existance branch May 28, 2025 05:12
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label May 28, 2025
@syphar syphar mentioned this pull request May 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@syphar @GuillaumeGomez