From 4683066ea0215bec6d7903b3cbaa700c51e90116 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Wed, 9 Jul 2025 11:23:58 +0200 Subject: [PATCH 1/3] Fix links color --- templates/style/style.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/templates/style/style.scss b/templates/style/style.scss index f6c9902ff..dd5ec025f 100644 --- a/templates/style/style.scss +++ b/templates/style/style.scss @@ -304,6 +304,10 @@ div.recent-releases-container { padding: 0.4em $search-result-right-left-padding; color: var(--color-standard); + a:not(.normal) { + color: var(--color-standard) + } + @media #{$media-lg} { padding: 0.4em 0; margin: 0 1em; From 0212ba67c1fdc9205eb682d510775f8394addf4a Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Wed, 9 Jul 2025 11:24:19 +0200 Subject: [PATCH 2/3] Add GUI test to ensure links have the expected color --- gui-tests/links-color.goml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 gui-tests/links-color.goml diff --git a/gui-tests/links-color.goml b/gui-tests/links-color.goml new file mode 100644 index 000000000..4c563ca55 --- /dev/null +++ b/gui-tests/links-color.goml @@ -0,0 +1,17 @@ +// Checks that the links have the expected color. +go-to: |DOC_PATH| +show-text: true + +// First we enforce the theme to ensure we're testing in the right conditions. +set-local-storage: {"rustdoc-theme": "light"} +reload: + +// The "Recent releases" and the feed icon should have the default color. +assert-css: ("//a[@href='/releases']", {"color": "#000"}) +assert-css: ("//a[@href='/releases/feed']", {"color": "#000"}) +// The release links should be different. +assert-css: ("li a.release .name", {"color": "#4d76ae"}, ALL) + +go-to: |DOC_PATH| + "/crate/sysinfo/0.23.5/builds" +// The builds link color should have the default color. +assert-css: ("li a.release > div", {"color": "#000"}, ALL) From f79e83e44226267bb014756095559b5538ac8d5f Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Wed, 9 Jul 2025 11:31:59 +0200 Subject: [PATCH 3/3] Update browser-ui-test version to `0.21.1` --- dockerfiles/Dockerfile-gui-tests | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dockerfiles/Dockerfile-gui-tests b/dockerfiles/Dockerfile-gui-tests index d31369e6c..17bca6464 100644 --- a/dockerfiles/Dockerfile-gui-tests +++ b/dockerfiles/Dockerfile-gui-tests @@ -74,7 +74,7 @@ RUN mkdir out # https://github.com/puppeteer/puppeteer/issues/375 # # We also specify the version in case we need to update it to go around cache limitations. -RUN npm install -g browser-ui-test@0.21.0 --unsafe-perm=true +RUN npm install -g browser-ui-test@0.21.1 --unsafe-perm=true EXPOSE 3000