Skip to content

Feedback on the 2024 edition import sorting page #355

@msrd0

Description

@msrd0

I just saw the new blog post and followed the link at the bottom and ended up on this page: https://doc.rust-lang.org/nightly/edition-guide/rust-2024/rustfmt-version-sorting.html. I have some feedback on the page.

The page mentions that the sorting now has better sorting for types with numbers in their name which I appreciate. Shown in the diff but not mentioned anywhere in the text is that lower-case names suddenly move from the front to the back, as seen by the std::io::stdout import in that example. I believe this change should be more clearly mentioned in the text as it can be quite a surprise to see that suddenly all your imports get shuffled around. It is also a change that creates a lot of unnecessary diff and one I'd like to not have (while still keeping all the other great changes in the new style edition), so if there is a flag to disable this behaviour it would be cool if that was documented as well.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions