Skip to content

Commit 13027f9

Browse files
committed
Auto merge of #132 - RalfJung:miri, r=Amanieu
Miri can catch panics now Also update some other Miri-related comments.
2 parents ffb5eec + 4ccc1a2 commit 13027f9

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

ci/miri.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ rustup default "$MIRI_NIGHTLY"
1212
rustup component add miri
1313
cargo miri setup
1414

15-
cargo miri test -- -- -Zunstable-options --exclude-should-panic
15+
cargo miri test

src/map.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2625,7 +2625,6 @@ mod test_map {
26252625
use super::DefaultHashBuilder;
26262626
use super::Entry::{Occupied, Vacant};
26272627
use super::{HashMap, RawEntryMut};
2628-
#[cfg(not(miri))]
26292628
use crate::CollectionAllocErr::*;
26302629
use rand::{rngs::SmallRng, Rng, SeedableRng};
26312630
use std::cell::RefCell;
@@ -2883,7 +2882,7 @@ mod test_map {
28832882
}
28842883

28852884
#[test]
2886-
#[cfg(not(miri))] // FIXME: https://github.com/rust-lang/miri/issues/654
2885+
#[cfg_attr(miri, ignore)] // FIXME: takes too long
28872886
fn test_lots_of_insertions() {
28882887
let mut m = HashMap::new();
28892888

@@ -3377,7 +3376,6 @@ mod test_map {
33773376

33783377
let mut m = HashMap::new();
33793378

3380-
// FIXME: https://github.com/rust-lang/miri/issues/653
33813379
let mut rng = {
33823380
let seed = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16];
33833381
SmallRng::from_seed(seed)
@@ -3491,7 +3489,7 @@ mod test_map {
34913489
}
34923490

34933491
#[test]
3494-
#[cfg(not(miri))] // FIXME: https://github.com/rust-lang/miri/issues/655
3492+
#[cfg_attr(miri, ignore)] // FIXME: no OOM signalling (https://github.com/rust-lang/miri/issues/613)
34953493
fn test_try_reserve() {
34963494
let mut empty_bytes: HashMap<u8, u8> = HashMap::new();
34973495

0 commit comments

Comments
 (0)