Skip to content

Commit 30c513c

Browse files
committed
Apply some clippy suggestions to tests
involving * calling `.clone()` on `&str`s, * calling `.clone()` on `const`s, * a transformation "x = x * 2" -> "x *= 2".
1 parent 813fa8a commit 30c513c

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/map.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3943,7 +3943,7 @@ mod test_map {
39433943
let vec = vec![(1, 1), (2, 2), (3, 3)];
39443944
let mut map: HashMap<_, _> = vec.into_iter().collect();
39453945
for value in map.values_mut() {
3946-
*value = (*value) * 2
3946+
*value *= 2
39473947
}
39483948
let values: Vec<_> = map.values().cloned().collect();
39493949
assert_eq!(values.len(), 3);
@@ -4327,11 +4327,11 @@ mod test_map {
43274327
let key = "hello there";
43284328
let value = "value goes here";
43294329
assert!(a.is_empty());
4330-
a.insert(key.clone(), value.clone());
4330+
a.insert(key, value);
43314331
assert_eq!(a.len(), 1);
43324332
assert_eq!(a[key], value);
43334333

4334-
match a.entry(key.clone()) {
4334+
match a.entry(key) {
43354335
Vacant(_) => panic!(),
43364336
Occupied(e) => assert_eq!(key, *e.key()),
43374337
}
@@ -4346,11 +4346,11 @@ mod test_map {
43464346
let value = "value goes here";
43474347

43484348
assert!(a.is_empty());
4349-
match a.entry(key.clone()) {
4349+
match a.entry(key) {
43504350
Occupied(_) => panic!(),
43514351
Vacant(e) => {
43524352
assert_eq!(key, *e.key());
4353-
e.insert(value.clone());
4353+
e.insert(value);
43544354
}
43554355
}
43564356
assert_eq!(a.len(), 1);
@@ -4876,7 +4876,7 @@ mod test_map {
48764876
const EMPTY_MAP: HashMap<u32, std::string::String, MyHasher> =
48774877
HashMap::with_hasher(MyHasher);
48784878

4879-
let mut map = EMPTY_MAP.clone();
4879+
let mut map = EMPTY_MAP;
48804880
map.insert(17, "seventeen".to_owned());
48814881
assert_eq!("seventeen", map[&17]);
48824882
}

src/set.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2278,7 +2278,7 @@ mod test_set {
22782278

22792279
const EMPTY_SET: HashSet<u32, MyHasher> = HashSet::with_hasher(MyHasher);
22802280

2281-
let mut set = EMPTY_SET.clone();
2281+
let mut set = EMPTY_SET;
22822282
set.insert(19);
22832283
assert!(set.contains(&19));
22842284
}

0 commit comments

Comments
 (0)