Remove mention of bumpalo feature.

Mention removal of that feature in changelog.
Remove BumpWrapper and its test.
Use another custom allocator in tests since
bumpalo support for allocator-api2 is not released.

Author: zakarumych

CHANGELOG.md

@@ -16,6 +16,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
 
 - Bumped MSRV to 1.63.0.
 
+### Removed
+
+- Support for `bumpalo` as an allocator with custom wrapper.
+  Use `allocator-api2` feature in `bumpalo` to use it as an allocator
+  for `hashbrown` collections.
 
 ## [v0.13.2] - 2023-01-12
 

Cargo.toml

@@ -35,6 +35,7 @@ rayon = "1.0"
 fnv = "1.0.7"
 serde_test = "1.0"
 doc-comment = "0.3.1"
+blink-alloc = "0.3.0"
 
 [features]
 default = ["ahash", "inline-more", "allocator-api2"]

README.md

@@ -105,8 +105,8 @@ This crate has the following Cargo features:
 - `raw`: Enables access to the experimental and unsafe `RawTable` API.
 - `inline-more`: Adds inline hints to most functions, improving run-time performance at the cost
   of compilation time. (enabled by default)
-- `bumpalo`: Provides a `BumpWrapper` type which allows `bumpalo` to be used for memory allocation.
 - `ahash`: Compiles with ahash as default hasher. (enabled by default)
+- `allocator-api2`: Enables support for allocators that support `allocator-api2`. (enabled by default)
 
 ## License
 

ci/run.sh

@@ -9,7 +9,7 @@ if [ "${NO_STD}" = "1" ]; then
     FEATURES="rustc-internal-api"
     OP="build"
 else
-    FEATURES="rustc-internal-api,serde,rayon,raw,bumpalo"
+    FEATURES="rustc-internal-api,serde,rayon,raw"
     OP="test"
 fi
 if [ "${CHANNEL}" = "nightly" ]; then
@@ -27,8 +27,8 @@ if [ "${CROSS}" = "1" ]; then
 fi
 
 # Make sure we can compile without the default hasher
-"${CARGO}" -vv build --target="${TARGET}" --no-default-features --features=allocator-api2
-"${CARGO}" -vv build --target="${TARGET}" --release --no-default-features --features=allocator-api2
+"${CARGO}" -vv build --target="${TARGET}" --no-default-features
+"${CARGO}" -vv build --target="${TARGET}" --release --no-default-features
 
 "${CARGO}" -vv ${OP} --target="${TARGET}"
 "${CARGO}" -vv ${OP} --target="${TARGET}" --features "${FEATURES}"

src/lib.rs

@@ -164,21 +164,3 @@ pub enum TryReserveError {
         layout: alloc::alloc::Layout,
     },
 }
-
-/// Wrapper around `Bump` which allows it to be used as an allocator for
-/// `HashMap`, `HashSet` and `RawTable`.
-///
-/// `Bump` can be used directly without this wrapper on nightly if you enable
-/// the `allocator-api` feature of the `bumpalo` crate.
-#[cfg(feature = "bumpalo")]
-#[derive(Clone, Copy, Debug)]
-pub struct BumpWrapper<'a>(pub &'a bumpalo::Bump);
-
-#[cfg(feature = "bumpalo")]
-#[test]
-fn test_bumpalo() {
-    use bumpalo::Bump;
-    let bump = Bump::new();
-    let mut map = HashMap::new_in(BumpWrapper(&bump));
-    map.insert(0, 1);
-}

src/map.rs

@@ -368,13 +368,13 @@ impl<K, V, A: Allocator + Clone> HashMap<K, V, DefaultHashBuilder, A> {
     /// # Examples
     ///
     /// ```
-    /// # #[cfg(feature = "bumpalo")]
+    /// # #[cfg(feature = "allocator-api2")]
     /// # fn test() {
-    /// use hashbrown::{HashMap, BumpWrapper};
-    /// use bumpalo::Bump;
+    /// use hashbrown::HashMap;
+    /// use blink_alloc::BlinkAlloc;
     ///
-    /// let bump = Bump::new();
-    /// let mut map = HashMap::new_in(BumpWrapper(&bump));
+    /// let blink = BlinkAlloc::new();
+    /// let mut map = HashMap::new_in(&blink);
     ///
     /// // The created HashMap holds none elements
     /// assert_eq!(map.len(), 0);
@@ -390,7 +390,7 @@ impl<K, V, A: Allocator + Clone> HashMap<K, V, DefaultHashBuilder, A> {
     /// assert!(map.capacity() > 1);
     /// # }
     /// # fn main() {
-    /// #     #[cfg(feature = "bumpalo")]
+    /// #     #[cfg(feature = "nightly")]
     /// #     test()
     /// # }
     /// ```
@@ -419,13 +419,13 @@ impl<K, V, A: Allocator + Clone> HashMap<K, V, DefaultHashBuilder, A> {
     /// # Examples
     ///
     /// ```
-    /// # #[cfg(feature = "bumpalo")]
+    /// # #[cfg(feature = "allocator-api2")]
     /// # fn test() {
-    /// use hashbrown::{HashMap, BumpWrapper};
-    /// use bumpalo::Bump;
+    /// use hashbrown::HashMap;
+    /// use blink_alloc::BlinkAlloc;
     ///
-    /// let bump = Bump::new();
-    /// let mut map = HashMap::with_capacity_in(5, BumpWrapper(&bump));
+    /// let blink = BlinkAlloc::new();
+    /// let mut map = HashMap::with_capacity_in(5, &blink);
     ///
     /// // The created HashMap holds none elements
     /// assert_eq!(map.len(), 0);
@@ -446,7 +446,7 @@ impl<K, V, A: Allocator + Clone> HashMap<K, V, DefaultHashBuilder, A> {
     /// assert_eq!(map.capacity(), empty_map_capacity)
     /// # }
     /// # fn main() {
-    /// #     #[cfg(feature = "bumpalo")]
+    /// #     #[cfg(feature = "allocator-api2")]
     /// #     test()
     /// # }
     /// ```