You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Auto merge of #2875 - jam1garner:fix-mips-o-largefile, r=JohnTitor
Fix incorrect constant for O_LARGEFILE on mips64-linux-musl
Changes `O_LARGEFILE` from `0` to `0x2000`
Bash script used for ensuring constant is correct:
```sh
#!/bin/bash
echo "
#include <fcntl.h>
int largefile() {
return O_LARGEFILE;
}
" | mips64-linux-musl-gcc -c -O2 musl_o_largefile.c -o temp.o
mips64-linux-musl-objdump -d temp.o | grep -A2 largefile
```
Output:
```asm
0000000000000000 <largefile>:
0: 03e00008 jr ra
4: 24022000 li v0,8192 ; 0x2000
```
Link to relevant portion of kernel source, shows that it should match mips32 musl (which currently has a value of 0x2000 as well).
I believe the reason #2738 had this value incorrect was because it's 0 for glibc on mips64 (to specify it's the default, I believe).
0 commit comments