Skip to content

Commit 2d72648

Browse files
fhahntru
authored andcommitted
[LV] Add more tests for interleave groups requiring predicates.
Adds tests for llvm#156849. Also tidies up the existing related test a bit. (cherry picked from commit a614807)
1 parent 81d3b6e commit 2d72648

File tree

2 files changed

+242
-124
lines changed

2 files changed

+242
-124
lines changed

llvm/test/Transforms/LoopVectorize/interleaved-accesses-3.ll

Lines changed: 0 additions & 124 deletions
This file was deleted.
Lines changed: 242 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,242 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --check-globals none --version 5
2+
; RUN: opt -S -passes=loop-vectorize,instcombine -force-vector-width=4 -force-vector-interleave=1 -enable-interleaved-mem-accesses=true < %s | FileCheck %s
3+
4+
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
5+
6+
; Check that the interleaved-mem-access analysis currently does not create an
7+
; interleave group for access 'a' due to the possible pointer wrap-around.
8+
;
9+
; To begin with, in this test the candidate interleave group can be created
10+
; only when getPtrStride is called with Assume=true. Next, because
11+
; the interleave-group of the loads is not full (has gaps), we also need to check
12+
; for possible pointer wrapping. Here we currently use Assume=false and as a
13+
; result cannot prove the transformation is safe and therefore invalidate the
14+
; candidate interleave group.
15+
;
16+
17+
; void func(unsigned * __restrict a, unsigned * __restrict b, unsigned char x, unsigned char y) {
18+
; int i = 0;
19+
; for (unsigned char index = x; i < y; index +=2, ++i)
20+
; b[i] = aptr 2;
21+
;
22+
; }
23+
24+
define void @wrap_around_scev_check(ptr noalias %a, ptr noalias %b, i8 %x, i8 %y) {
25+
; CHECK-LABEL: define void @wrap_around_scev_check(
26+
; CHECK-SAME: ptr noalias [[A:%.*]], ptr noalias [[B:%.*]], i8 [[X:%.*]], i8 [[Y:%.*]]) {
27+
; CHECK-NEXT: [[ENTRY:.*:]]
28+
; CHECK-NEXT: [[CMP9:%.*]] = icmp eq i8 [[Y]], 0
29+
; CHECK-NEXT: br i1 [[CMP9]], label %[[EXIT:.*]], label %[[LOOP_PREHEADER:.*]]
30+
; CHECK: [[LOOP_PREHEADER]]:
31+
; CHECK-NEXT: [[WIDE_TRIP_COUNT:%.*]] = zext i8 [[Y]] to i64
32+
; CHECK-NEXT: [[MIN_ITERS_CHECK:%.*]] = icmp ult i8 [[Y]], 5
33+
; CHECK-NEXT: br i1 [[MIN_ITERS_CHECK]], label %[[SCALAR_PH:.*]], label %[[VECTOR_SCEVCHECK:.*]]
34+
; CHECK: [[VECTOR_SCEVCHECK]]:
35+
; CHECK-NEXT: [[TMP0:%.*]] = add nsw i64 [[WIDE_TRIP_COUNT]], -1
36+
; CHECK-NEXT: [[TMP1:%.*]] = trunc i64 [[TMP0]] to i8
37+
; CHECK-NEXT: [[MUL_RESULT:%.*]] = shl i8 [[TMP1]], 1
38+
; CHECK-NEXT: [[TMP2:%.*]] = xor i8 [[X]], -1
39+
; CHECK-NEXT: [[TMP3:%.*]] = icmp ugt i8 [[MUL_RESULT]], [[TMP2]]
40+
; CHECK-NEXT: [[TMP4:%.*]] = icmp ugt i64 [[TMP0]], 127
41+
; CHECK-NEXT: [[TMP5:%.*]] = or i1 [[TMP3]], [[TMP4]]
42+
; CHECK-NEXT: br i1 [[TMP5]], label %[[SCALAR_PH]], label %[[VECTOR_PH:.*]]
43+
; CHECK: [[VECTOR_PH]]:
44+
; CHECK-NEXT: [[N_MOD_VF:%.*]] = and i64 [[WIDE_TRIP_COUNT]], 3
45+
; CHECK-NEXT: [[TMP6:%.*]] = icmp eq i64 [[N_MOD_VF]], 0
46+
; CHECK-NEXT: [[TMP7:%.*]] = select i1 [[TMP6]], i64 4, i64 [[N_MOD_VF]]
47+
; CHECK-NEXT: [[N_VEC:%.*]] = sub nsw i64 [[WIDE_TRIP_COUNT]], [[TMP7]]
48+
; CHECK-NEXT: [[DOTCAST:%.*]] = trunc i64 [[N_VEC]] to i8
49+
; CHECK-NEXT: [[TMP8:%.*]] = shl i8 [[DOTCAST]], 1
50+
; CHECK-NEXT: [[TMP9:%.*]] = add i8 [[X]], [[TMP8]]
51+
; CHECK-NEXT: br label %[[VECTOR_BODY:.*]]
52+
; CHECK: [[VECTOR_BODY]]:
53+
; CHECK-NEXT: [[INDEX:%.*]] = phi i64 [ 0, %[[VECTOR_PH]] ], [ [[INDEX_NEXT:%.*]], %[[VECTOR_BODY]] ]
54+
; CHECK-NEXT: [[DOTCAST2:%.*]] = trunc i64 [[INDEX]] to i8
55+
; CHECK-NEXT: [[TMP10:%.*]] = shl i8 [[DOTCAST2]], 1
56+
; CHECK-NEXT: [[OFFSET_IDX:%.*]] = add i8 [[X]], [[TMP10]]
57+
; CHECK-NEXT: [[TMP11:%.*]] = zext i8 [[OFFSET_IDX]] to i64
58+
; CHECK-NEXT: [[TMP12:%.*]] = getelementptr inbounds nuw i32, ptr [[A]], i64 [[TMP11]]
59+
; CHECK-NEXT: [[WIDE_VEC:%.*]] = load <8 x i32>, ptr [[TMP12]], align 4
60+
; CHECK-NEXT: [[STRIDED_VEC:%.*]] = shufflevector <8 x i32> [[WIDE_VEC]], <8 x i32> poison, <4 x i32> <i32 0, i32 2, i32 4, i32 6>
61+
; CHECK-NEXT: [[TMP13:%.*]] = shl <4 x i32> [[STRIDED_VEC]], splat (i32 1)
62+
; CHECK-NEXT: [[TMP14:%.*]] = getelementptr inbounds i32, ptr [[B]], i64 [[INDEX]]
63+
; CHECK-NEXT: store <4 x i32> [[TMP13]], ptr [[TMP14]], align 4
64+
; CHECK-NEXT: [[INDEX_NEXT]] = add nuw i64 [[INDEX]], 4
65+
; CHECK-NEXT: [[TMP15:%.*]] = icmp eq i64 [[INDEX_NEXT]], [[N_VEC]]
66+
; CHECK-NEXT: br i1 [[TMP15]], label %[[MIDDLE_BLOCK:.*]], label %[[VECTOR_BODY]], !llvm.loop [[LOOP0:![0-9]+]]
67+
; CHECK: [[MIDDLE_BLOCK]]:
68+
; CHECK-NEXT: br label %[[SCALAR_PH]]
69+
; CHECK: [[SCALAR_PH]]:
70+
; CHECK-NEXT: [[BC_RESUME_VAL:%.*]] = phi i64 [ [[N_VEC]], %[[MIDDLE_BLOCK]] ], [ 0, %[[LOOP_PREHEADER]] ], [ 0, %[[VECTOR_SCEVCHECK]] ]
71+
; CHECK-NEXT: [[BC_RESUME_VAL3:%.*]] = phi i8 [ [[TMP9]], %[[MIDDLE_BLOCK]] ], [ [[X]], %[[LOOP_PREHEADER]] ], [ [[X]], %[[VECTOR_SCEVCHECK]] ]
72+
; CHECK-NEXT: br label %[[LOOP:.*]]
73+
; CHECK: [[LOOP]]:
74+
; CHECK-NEXT: [[IV:%.*]] = phi i64 [ [[BC_RESUME_VAL]], %[[SCALAR_PH]] ], [ [[IV_NEXT:%.*]], %[[LOOP]] ]
75+
; CHECK-NEXT: [[INDEX_011:%.*]] = phi i8 [ [[BC_RESUME_VAL3]], %[[SCALAR_PH]] ], [ [[ADD:%.*]], %[[LOOP]] ]
76+
; CHECK-NEXT: [[IDXPROM:%.*]] = zext i8 [[INDEX_011]] to i64
77+
; CHECK-NEXT: [[ARRAYIDX:%.*]] = getelementptr inbounds nuw i32, ptr [[A]], i64 [[IDXPROM]]
78+
; CHECK-NEXT: [[TMP16:%.*]] = load i32, ptr [[ARRAYIDX]], align 4
79+
; CHECK-NEXT: [[MUL:%.*]] = shl i32 [[TMP16]], 1
80+
; CHECK-NEXT: [[ARRAYIDX2:%.*]] = getelementptr inbounds i32, ptr [[B]], i64 [[IV]]
81+
; CHECK-NEXT: store i32 [[MUL]], ptr [[ARRAYIDX2]], align 4
82+
; CHECK-NEXT: [[ADD]] = add i8 [[INDEX_011]], 2
83+
; CHECK-NEXT: [[IV_NEXT]] = add nuw nsw i64 [[IV]], 1
84+
; CHECK-NEXT: [[EXITCOND:%.*]] = icmp eq i64 [[IV_NEXT]], [[WIDE_TRIP_COUNT]]
85+
; CHECK-NEXT: br i1 [[EXITCOND]], label %[[EXIT_LOOPEXIT:.*]], label %[[LOOP]], !llvm.loop [[LOOP3:![0-9]+]]
86+
; CHECK: [[EXIT_LOOPEXIT]]:
87+
; CHECK-NEXT: br label %[[EXIT]]
88+
; CHECK: [[EXIT]]:
89+
; CHECK-NEXT: ret void
90+
;
91+
entry:
92+
%cmp9 = icmp eq i8 %y, 0
93+
br i1 %cmp9, label %exit, label %loop.preheader
94+
95+
loop.preheader:
96+
%wide.trip.count = zext i8 %y to i64
97+
br label %loop
98+
99+
loop:
100+
%iv = phi i64 [ 0, %loop.preheader ], [ %iv.next, %loop ]
101+
%index.011 = phi i8 [ %x, %loop.preheader ], [ %add, %loop ]
102+
%idxprom = zext i8 %index.011 to i64
103+
%arrayidx = getelementptr inbounds i32, ptr %a, i64 %idxprom
104+
%0 = load i32, ptr %arrayidx, align 4
105+
%mul = shl i32 %0, 1
106+
%arrayidx2 = getelementptr inbounds i32, ptr %b, i64 %iv
107+
store i32 %mul, ptr %arrayidx2, align 4
108+
%add = add i8 %index.011, 2
109+
%iv.next = add nuw nsw i64 %iv, 1
110+
%exitcond = icmp eq i64 %iv.next, %wide.trip.count
111+
br i1 %exitcond, label %exit, label %loop
112+
113+
exit:
114+
ret void
115+
}
116+
117+
; For %gep, we have the following SCEV: ((4 * (zext i4 {0,+,5}<%loop> to i64))<nuw><nsw> + %x).
118+
; Note the i4 bit wide AddRec {0,+,5}. It is known to wrap in the loop with trip count 16.
119+
; FIXME: Currently we incorrectly assume the widened AddRec does not wrap.
120+
define void @wrap_predicate_for_interleave_group_wraps_for_known_trip_count(ptr noalias %x, ptr noalias %out) {
121+
; CHECK-LABEL: define void @wrap_predicate_for_interleave_group_wraps_for_known_trip_count(
122+
; CHECK-SAME: ptr noalias [[X:%.*]], ptr noalias [[OUT:%.*]]) {
123+
; CHECK-NEXT: [[START:.*:]]
124+
; CHECK-NEXT: br i1 false, label %[[SCALAR_PH:.*]], label %[[VECTOR_PH:.*]]
125+
; CHECK: [[VECTOR_PH]]:
126+
; CHECK-NEXT: br label %[[VECTOR_BODY:.*]]
127+
; CHECK: [[VECTOR_BODY]]:
128+
; CHECK-NEXT: [[INDEX:%.*]] = phi i64 [ 0, %[[VECTOR_PH]] ], [ [[INDEX_NEXT:%.*]], %[[VECTOR_BODY]] ]
129+
; CHECK-NEXT: [[TMP0:%.*]] = mul nuw nsw i64 [[INDEX]], 5
130+
; CHECK-NEXT: [[TMP1:%.*]] = and i64 [[TMP0]], 12
131+
; CHECK-NEXT: [[TMP2:%.*]] = getelementptr inbounds nuw i32, ptr [[X]], i64 [[TMP1]]
132+
; CHECK-NEXT: [[WIDE_VEC:%.*]] = load <20 x i32>, ptr [[TMP2]], align 4
133+
; CHECK-NEXT: [[STRIDED_VEC:%.*]] = shufflevector <20 x i32> [[WIDE_VEC]], <20 x i32> poison, <4 x i32> <i32 0, i32 5, i32 10, i32 15>
134+
; CHECK-NEXT: [[TMP3:%.*]] = getelementptr inbounds nuw i32, ptr [[OUT]], i64 [[INDEX]]
135+
; CHECK-NEXT: store <4 x i32> [[STRIDED_VEC]], ptr [[TMP3]], align 4
136+
; CHECK-NEXT: [[INDEX_NEXT]] = add nuw i64 [[INDEX]], 4
137+
; CHECK-NEXT: [[TMP4:%.*]] = icmp eq i64 [[INDEX_NEXT]], 12
138+
; CHECK-NEXT: br i1 [[TMP4]], label %[[MIDDLE_BLOCK:.*]], label %[[VECTOR_BODY]], !llvm.loop [[LOOP4:![0-9]+]]
139+
; CHECK: [[MIDDLE_BLOCK]]:
140+
; CHECK-NEXT: br label %[[SCALAR_PH]]
141+
; CHECK: [[SCALAR_PH]]:
142+
; CHECK-NEXT: br label %[[LOOP:.*]]
143+
; CHECK: [[LOOP]]:
144+
; CHECK-NEXT: [[IV:%.*]] = phi i64 [ 12, %[[SCALAR_PH]] ], [ [[IV_NEXT:%.*]], %[[LOOP]] ]
145+
; CHECK-NEXT: [[IV_NEXT]] = add nuw nsw i64 [[IV]], 1
146+
; CHECK-NEXT: [[IV_MUL5:%.*]] = mul nuw nsw i64 [[IV]], 5
147+
; CHECK-NEXT: [[IV_MUL5_MASKED:%.*]] = and i64 [[IV_MUL5]], 15
148+
; CHECK-NEXT: [[GEP:%.*]] = getelementptr inbounds nuw i32, ptr [[X]], i64 [[IV_MUL5_MASKED]]
149+
; CHECK-NEXT: [[V:%.*]] = load i32, ptr [[GEP]], align 4
150+
; CHECK-NEXT: [[OUT_I:%.*]] = getelementptr inbounds nuw i32, ptr [[OUT]], i64 [[IV]]
151+
; CHECK-NEXT: store i32 [[V]], ptr [[OUT_I]], align 4
152+
; CHECK-NEXT: [[EXITCOND_NOT:%.*]] = icmp eq i64 [[IV_NEXT]], 16
153+
; CHECK-NEXT: br i1 [[EXITCOND_NOT]], label %[[EXIT:.*]], label %[[LOOP]], !llvm.loop [[LOOP5:![0-9]+]]
154+
; CHECK: [[EXIT]]:
155+
; CHECK-NEXT: ret void
156+
;
157+
start:
158+
br label %loop
159+
160+
loop:
161+
%iv = phi i64 [ 0, %start ], [ %iv.next, %loop ]
162+
%iv.next = add nuw nsw i64 %iv, 1
163+
%iv.mul5 = mul nuw nsw i64 %iv, 5
164+
%iv.mul5.masked = and i64 %iv.mul5, 15
165+
%gep = getelementptr inbounds nuw i32, ptr %x, i64 %iv.mul5.masked
166+
%v = load i32, ptr %gep, align 4
167+
%out.i = getelementptr inbounds nuw i32, ptr %out, i64 %iv
168+
store i32 %v, ptr %out.i, align 4
169+
%exitcond.not = icmp eq i64 %iv.next, 16
170+
br i1 %exitcond.not, label %exit, label %loop
171+
172+
exit:
173+
ret void
174+
}
175+
176+
; For %gep, we have the following SCEV: ((4 * (zext i4 {0,+,3}<%loop> to i64))<nuw><nsw> + %x).
177+
; Note the i4 bit wide AddRec {0,+,3}. It may wrap, depending on the trip count.
178+
define void @wrap_predicate_for_interleave_group_unknown_trip_count(ptr noalias %x, ptr noalias %out, i64 %n) {
179+
; CHECK-LABEL: define void @wrap_predicate_for_interleave_group_unknown_trip_count(
180+
; CHECK-SAME: ptr noalias [[X:%.*]], ptr noalias [[OUT:%.*]], i64 [[N:%.*]]) {
181+
; CHECK-NEXT: [[START:.*]]:
182+
; CHECK-NEXT: [[MIN_ITERS_CHECK:%.*]] = icmp ult i64 [[N]], 5
183+
; CHECK-NEXT: br i1 [[MIN_ITERS_CHECK]], label %[[SCALAR_PH:.*]], label %[[VECTOR_SCEVCHECK:.*]]
184+
; CHECK: [[VECTOR_SCEVCHECK]]:
185+
; CHECK-NEXT: [[TMP0:%.*]] = add i64 [[N]], -17
186+
; CHECK-NEXT: [[TMP1:%.*]] = icmp ult i64 [[TMP0]], -16
187+
; CHECK-NEXT: br i1 [[TMP1]], label %[[SCALAR_PH]], label %[[VECTOR_PH:.*]]
188+
; CHECK: [[VECTOR_PH]]:
189+
; CHECK-NEXT: [[N_MOD_VF:%.*]] = and i64 [[N]], 3
190+
; CHECK-NEXT: [[TMP2:%.*]] = icmp eq i64 [[N_MOD_VF]], 0
191+
; CHECK-NEXT: [[TMP7:%.*]] = select i1 [[TMP2]], i64 4, i64 [[N_MOD_VF]]
192+
; CHECK-NEXT: [[N_VEC:%.*]] = sub nsw i64 [[N]], [[TMP7]]
193+
; CHECK-NEXT: br label %[[VECTOR_BODY:.*]]
194+
; CHECK: [[VECTOR_BODY]]:
195+
; CHECK-NEXT: [[INDEX:%.*]] = phi i64 [ 0, %[[VECTOR_PH]] ], [ [[INDEX_NEXT:%.*]], %[[VECTOR_BODY]] ]
196+
; CHECK-NEXT: [[TMP8:%.*]] = mul nuw nsw i64 [[INDEX]], 3
197+
; CHECK-NEXT: [[TMP3:%.*]] = and i64 [[TMP8]], 12
198+
; CHECK-NEXT: [[TMP4:%.*]] = getelementptr inbounds nuw i32, ptr [[X]], i64 [[TMP3]]
199+
; CHECK-NEXT: [[WIDE_VEC:%.*]] = load <12 x i32>, ptr [[TMP4]], align 4
200+
; CHECK-NEXT: [[STRIDED_VEC:%.*]] = shufflevector <12 x i32> [[WIDE_VEC]], <12 x i32> poison, <4 x i32> <i32 0, i32 3, i32 6, i32 9>
201+
; CHECK-NEXT: [[TMP5:%.*]] = getelementptr inbounds nuw i32, ptr [[OUT]], i64 [[INDEX]]
202+
; CHECK-NEXT: store <4 x i32> [[STRIDED_VEC]], ptr [[TMP5]], align 4
203+
; CHECK-NEXT: [[INDEX_NEXT]] = add nuw i64 [[INDEX]], 4
204+
; CHECK-NEXT: [[TMP6:%.*]] = icmp eq i64 [[INDEX_NEXT]], [[N_VEC]]
205+
; CHECK-NEXT: br i1 [[TMP6]], label %[[MIDDLE_BLOCK:.*]], label %[[VECTOR_BODY]], !llvm.loop [[LOOP6:![0-9]+]]
206+
; CHECK: [[MIDDLE_BLOCK]]:
207+
; CHECK-NEXT: br label %[[SCALAR_PH]]
208+
; CHECK: [[SCALAR_PH]]:
209+
; CHECK-NEXT: [[BC_RESUME_VAL:%.*]] = phi i64 [ [[N_VEC]], %[[MIDDLE_BLOCK]] ], [ 0, %[[START]] ], [ 0, %[[VECTOR_SCEVCHECK]] ]
210+
; CHECK-NEXT: br label %[[LOOP:.*]]
211+
; CHECK: [[LOOP]]:
212+
; CHECK-NEXT: [[IV:%.*]] = phi i64 [ [[BC_RESUME_VAL]], %[[SCALAR_PH]] ], [ [[IV_NEXT:%.*]], %[[LOOP]] ]
213+
; CHECK-NEXT: [[IV_NEXT]] = add nuw nsw i64 [[IV]], 1
214+
; CHECK-NEXT: [[IV_MUL5:%.*]] = mul nuw nsw i64 [[IV]], 3
215+
; CHECK-NEXT: [[IV_MUL5_MASKED:%.*]] = and i64 [[IV_MUL5]], 15
216+
; CHECK-NEXT: [[GEP:%.*]] = getelementptr inbounds nuw i32, ptr [[X]], i64 [[IV_MUL5_MASKED]]
217+
; CHECK-NEXT: [[V:%.*]] = load i32, ptr [[GEP]], align 4
218+
; CHECK-NEXT: [[OUT_I:%.*]] = getelementptr inbounds nuw i32, ptr [[OUT]], i64 [[IV]]
219+
; CHECK-NEXT: store i32 [[V]], ptr [[OUT_I]], align 4
220+
; CHECK-NEXT: [[EXITCOND_NOT:%.*]] = icmp eq i64 [[IV_NEXT]], [[N]]
221+
; CHECK-NEXT: br i1 [[EXITCOND_NOT]], label %[[EXIT:.*]], label %[[LOOP]], !llvm.loop [[LOOP7:![0-9]+]]
222+
; CHECK: [[EXIT]]:
223+
; CHECK-NEXT: ret void
224+
;
225+
start:
226+
br label %loop
227+
228+
loop:
229+
%iv = phi i64 [ 0, %start ], [ %iv.next, %loop ]
230+
%iv.next = add nuw nsw i64 %iv, 1
231+
%iv.mul3 = mul nuw nsw i64 %iv, 3
232+
%iv.mul3.masked = and i64 %iv.mul3, 15
233+
%gep = getelementptr inbounds nuw i32, ptr %x, i64 %iv.mul3.masked
234+
%v = load i32, ptr %gep, align 4
235+
%out.i = getelementptr inbounds nuw i32, ptr %out, i64 %iv
236+
store i32 %v, ptr %out.i, align 4
237+
%exitcond.not = icmp eq i64 %iv.next, %n
238+
br i1 %exitcond.not, label %exit, label %loop
239+
240+
exit:
241+
ret void
242+
}

0 commit comments

Comments
 (0)