Remove the MmapSerializationSink.

Author: michaelwoerister

analyzeme/benches/serialization_bench.rs

@@ -3,7 +3,7 @@
 extern crate test;
 
 use analyzeme::testing_common;
-use measureme::{FileSerializationSink, MmapSerializationSink};
+use measureme::FileSerializationSink;
 
 #[bench]
 fn bench_file_serialization_sink(bencher: &mut test::Bencher) {
@@ -16,17 +16,6 @@ fn bench_file_serialization_sink(bencher: &mut test::Bencher) {
     });
 }
 
-#[bench]
-fn bench_mmap_serialization_sink(bencher: &mut test::Bencher) {
-    bencher.iter(|| {
-        testing_common::run_serialization_bench::<MmapSerializationSink>(
-            "mmap_serialization_sink_test",
-            500_000,
-            1,
-        );
-    });
-}
-
 #[bench]
 fn bench_file_serialization_sink_8_threads(bencher: &mut test::Bencher) {
     bencher.iter(|| {
@@ -37,14 +26,3 @@ fn bench_file_serialization_sink_8_threads(bencher: &mut test::Bencher) {
         );
     });
 }
-
-#[bench]
-fn bench_mmap_serialization_sink_8_threads(bencher: &mut test::Bencher) {
-    bencher.iter(|| {
-        testing_common::run_serialization_bench::<MmapSerializationSink>(
-            "mmap_serialization_sink_test",
-            50_000,
-            8,
-        );
-    });
-}

analyzeme/tests/serialization.rs

@@ -1,5 +1,5 @@
 use analyzeme::testing_common::run_end_to_end_serialization_test;
-use measureme::{FileSerializationSink, MmapSerializationSink};
+use measureme::FileSerializationSink;
 
 #[test]
 fn test_file_serialization_sink_1_thread() {
@@ -16,19 +16,3 @@ fn test_file_serialization_sink_8_threads() {
         8,
     );
 }
-
-#[test]
-fn test_mmap_serialization_sink_1_thread() {
-    run_end_to_end_serialization_test::<MmapSerializationSink>(
-        "mmap_serialization_sink_test_1_thread",
-        1,
-    );
-}
-
-#[test]
-fn test_mmap_serialization_sink_8_threads() {
-    run_end_to_end_serialization_test::<MmapSerializationSink>(
-        "mmap_serialization_sink_test_8_threads",
-        8,
-    );
-}

measureme/Cargo.toml

@@ -15,6 +15,3 @@ travis-ci = { repository = "rust-lang/measureme" }
 [dependencies]
 rustc-hash = "1.0.1"
 parking_lot = "0.11.0"
-
-[target.'cfg(not(target_arch="wasm32"))'.dependencies]
-memmap = "0.7"

measureme/src/lib.rs

@@ -43,7 +43,6 @@ pub mod file_header;
 #[cfg(any(not(target_arch = "wasm32"), target_os = "wasi"))]
 mod file_serialization_sink;
 #[cfg(not(target_arch = "wasm32"))]
-mod mmap_serialization_sink;
 mod profiler;
 mod raw_event;
 mod serialization;
@@ -55,7 +54,6 @@ pub use crate::event_id::{EventId, EventIdBuilder};
 #[cfg(any(not(target_arch = "wasm32"), target_os = "wasi"))]
 pub use crate::file_serialization_sink::FileSerializationSink;
 #[cfg(not(target_arch = "wasm32"))]
-pub use crate::mmap_serialization_sink::MmapSerializationSink;
 pub use crate::profiler::{Profiler, ProfilerFiles, TimingGuard};
 pub use crate::raw_event::{RawEvent, MAX_INSTANT_TIMESTAMP, MAX_INTERVAL_TIMESTAMP};
 pub use crate::serialization::{Addr, SerializationSink};