Skip to content

Commit 32bc015

Browse files
committed
reorganize comments for shim's classification
1 parent bc7513b commit 32bc015

File tree

4 files changed

+10
-5
lines changed

4 files changed

+10
-5
lines changed

src/shims/foreign_items/posix.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx
104104
this.write_scalar(Scalar::from_int(result, dest.layout.size), dest)?;
105105
}
106106

107+
// Other shims
107108
"posix_memalign" => {
108109
let ret = this.deref_operand(args[0])?;
109110
let align = this.read_scalar(args[1])?.to_machine_usize(this)?;

src/shims/foreign_items/posix/linux.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx
4040
this.write_scalar(Scalar::from_int(result, dest.layout.size), dest)?;
4141
}
4242

43+
// Other shims
4344
"pthread_getattr_np" => {
4445
this.write_null(dest)?;
4546
}

src/shims/foreign_items/posix/macos.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx
5555
this.write_scalar(Scalar::from_int(result, dest.layout.size), dest)?;
5656
}
5757

58-
// macOS API stubs.
58+
// Other shims
5959
"pthread_attr_get_np" => {
6060
this.write_null(dest)?;
6161
}

src/shims/foreign_items/windows.rs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx
1616
let tcx = &{ this.tcx.tcx };
1717

1818
match link_name {
19+
// Windows API stubs.
20+
// HANDLE = isize
21+
// DWORD = ULONG = u32
22+
// BOOL = i32
23+
1924
// Environment related shims
2025
"GetEnvironmentVariableW" => {
2126
// args[0] : LPCWSTR lpName (32-bit ptr to a const string of 16-bit Unicode chars)
@@ -70,10 +75,8 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx
7075
dest,
7176
)?;
7277
}
73-
// Windows API stubs.
74-
// HANDLE = isize
75-
// DWORD = ULONG = u32
76-
// BOOL = i32
78+
79+
// Other shims
7780
"GetProcessHeap" => {
7881
// Just fake a HANDLE
7982
this.write_scalar(Scalar::from_int(1, this.pointer_size()), dest)?;

0 commit comments

Comments
 (0)