Cleanup

Author: Patrick-6

genmc-sys/src/lib.rs

@@ -28,7 +28,7 @@ impl Default for GenmcParams {
             print_random_schedule_seed: false,
             quiet: true,
             log_level_trace: false,
-            do_symmetry_reduction: false, // TODO GENMC (PERFORMANCE): maybe make this default `true`
+            do_symmetry_reduction: false,
         }
     }
 }

src/concurrency/data_race.rs

@@ -71,7 +71,7 @@ pub enum AtomicRwOrd {
 }
 
 /// Valid atomic read orderings, subset of atomic::Ordering.
-#[derive(Copy, Clone, PartialEq, Eq, Debug, Hash)]
+#[derive(Copy, Clone, PartialEq, Eq, Debug)]
 pub enum AtomicReadOrd {
     Relaxed,
     Acquire,
@@ -1016,7 +1016,6 @@ pub trait EvalContextExt<'tcx>: MiriInterpCxExt<'tcx> {
         if let Some(data_race) = this.machine.data_race.as_vclocks_ref() {
             data_race.acquire_clock(clock, &this.machine.threads);
         }
-        // TODO GENMC: does GenMC need to be informed about this?
     }
 }
 

src/concurrency/thread.rs

@@ -586,8 +586,6 @@ impl<'tcx> ThreadManager<'tcx> {
     fn detach_thread(&mut self, id: ThreadId, allow_terminated_joined: bool) -> InterpResult<'tcx> {
         trace!("detaching {:?}", id);
 
-        tracing::info!("GenMC: TODO GENMC: does GenMC need special handling for detached threads?");
-
         let is_ub = if allow_terminated_joined && self.threads[id].state.is_terminated() {
             // "Detached" in particular means "not yet joined". Redundant detaching is still UB.
             self.threads[id].join_status == ThreadJoinStatus::Detached