Rollup merge of #144914 - estebank:short-paths-2, r=fee1-dead

Add support for `ty::Instance` path shortening in diagnostics

Make `ty::Instance` able to use `short_string` and usable in structured errors directly. Remove some ad-hoc type shortening logic.

Author: Zalathar