-
Notifications
You must be signed in to change notification settings - Fork 395
Implement std::sync::Mutex interception for GenMC mode. #4614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for contributing to Miri! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder, once the PR becomes ready for a review, use |
This failure is weird, the |
You probably need to rebase over #4617 yeah. |
afdb725
to
f60d084
Compare
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
The rebase fixed the previous CI failure, but there is another one now, possibly spurious? Nothing in this PR should affect Windows, or Linux on Arm specifically. |
Yeah those are just network timeouts, you can ignore them. |
This looks great, thanks! Please squash the commits using @rustbot author |
5d8eaf6
to
8923247
Compare
@rustbot ready |
This PR adds support for Miri to intercept uses of
std::sync::Mutex
using the rustc diagnostic items added in rust-lang/rust#141690.