Fix clippy issues

Author: gnzlbg

ci/all.sh

@@ -4,7 +4,7 @@
 
 set -ex
 
-: ${1?"The all.sh script requires one argument."}
+: "${1?The all.sh script requires one argument.}"
 
 op=$1
 
@@ -54,11 +54,18 @@ $CMD
 for dir in examples/*/
 do
     dir=${dir%*/}
-    cd ${dir%*/}
-    $CMD
-    cd -
+    (
+        cd "${dir%*/}"
+        $CMD
+    )
 done
 
-cd verify/verify
-$CMD
-cd -
+(
+    cd verify/verify
+    $CMD
+)
+
+(
+    cd micro_benchmarks
+    $CMD
+)

examples/aobench/benches/isec_plane.rs

@@ -3,9 +3,9 @@
 
 use criterion::*;
 
-use aobench_lib::*;
 use crate::geometry::{f32xN, Plane, Ray, RayxN, V3DxN, V3D};
 use crate::intersection::{Intersect, Isect, IsectxN};
+use aobench_lib::*;
 
 fn hit_scalar(c: &mut Criterion) {
     let mut s = Plane {

examples/aobench/benches/isec_sphere.rs

@@ -1,9 +1,9 @@
 //! Benchmarks intersection between rays and spheres
 #![feature(stdsimd)]
 
-use aobench_lib::*;
 use crate::geometry::{f32xN, Ray, RayxN, Sphere, V3DxN, V3D};
 use crate::intersection::{Intersect, Isect, IsectxN};
+use aobench_lib::*;
 use criterion::*;
 use test::*;
 

examples/aobench/src/lib.rs

@@ -4,18 +4,15 @@
 //! Fujita.
 #![deny(warnings, rust_2018_idioms)]
 #![allow(non_snake_case, non_camel_case_types)]
-#![cfg_attr(
-    feature = "cargo-clippy",
-    allow(
-        clippy::many_single_char_names,
-        clippy::similar_names,
-        clippy::cast_precision_loss,
-        clippy::inline_always,
-        clippy::cast_possible_truncation,
-        clippy::cast_sign_loss,
-        clippy::identity_op,
-        clippy::erasing_op
-    )
+#![allow(
+    clippy::many_single_char_names,
+    clippy::similar_names,
+    clippy::cast_precision_loss,
+    clippy::inline_always,
+    clippy::cast_possible_truncation,
+    clippy::cast_sign_loss,
+    clippy::identity_op,
+    clippy::erasing_op
 )]
 
 pub mod ambient_occlusion;

examples/aobench/src/tiled.rs

@@ -1,10 +1,10 @@
 //! SIMD serial aobench
 
-use cfg_if::cfg_if;
 use crate::ambient_occlusion;
 use crate::geometry::{f32xN, pf32xN, usizexN, IncrV, RayxN, V3DxN};
 use crate::intersection::{Intersect, IsectxN};
 use crate::scene::Scene;
+use cfg_if::cfg_if;
 
 #[inline(always)]
 fn ao_impl<S: Scene>(

examples/aobench/src/vector.rs

@@ -1,10 +1,10 @@
 //! SIMD serial aobench
 
-use cfg_if::cfg_if;
 use crate::ambient_occlusion;
 use crate::geometry::{Ray, V3D};
 use crate::intersection::{Intersect, Isect};
 use crate::scene::Scene;
+use cfg_if::cfg_if;
 
 #[inline(always)]
 fn ao_impl<S: Scene>(

examples/fannkuch_redux/src/lib.rs

@@ -1,15 +1,12 @@
 //! Fannkuch redux
 #![deny(warnings, rust_2018_idioms)]
 #![allow(non_snake_case, non_camel_case_types)]
-#![cfg_attr(
-    feature = "cargo-clippy",
-    allow(
-        clippy::similar_names,
-        clippy::many_single_char_names,
-        clippy::cast_possible_truncation,
-        clippy::cast_sign_loss,
-        clippy::cast_possible_wrap
-    )
+#![allow(
+    clippy::similar_names,
+    clippy::many_single_char_names,
+    clippy::cast_possible_truncation,
+    clippy::cast_sign_loss,
+    clippy::cast_possible_wrap
 )]
 
 pub mod scalar;

examples/mandelbrot/src/lib.rs

@@ -3,13 +3,10 @@
 //! [bg]: https://benchmarksgame-team.pages.debian.net/benchmarksgame/description/mandelbrot.html#mandelbrot
 
 #![deny(warnings, rust_2018_idioms)]
-#![cfg_attr(
-    feature = "cargo-clippy",
-    allow(
-        clippy::cast_precision_loss,
-        clippy::cast_sign_loss,
-        clippy::cast_possible_truncation
-    )
+#![allow(
+    clippy::cast_precision_loss,
+    clippy::cast_sign_loss,
+    clippy::cast_possible_truncation
 )]
 
 use rayon::prelude::*;

examples/matrix_inverse/src/scalar.rs

@@ -2,7 +2,7 @@
 #![rustfmt::skip]
 use crate::*;
 
-#[cfg_attr(feature = "cargo-clippy", allow(clippy::too_many_lines))]
+#[allow(clippy::too_many_lines)]
 pub fn inv4x4(m: Matrix4x4) -> Option<Matrix4x4> {
     let m = m.0;
 

examples/nbody/src/lib.rs

@@ -2,10 +2,7 @@
 //!
 //! [bg]: https://benchmarksgame-team.pages.debian.net/benchmarksgame/description/nbody.html#nbody
 #![deny(warnings, rust_2018_idioms)]
-#![cfg_attr(
-    feature = "cargo-clippy",
-    allow(clippy::similar_names, clippy::excessive_precision)
-)]
+#![allow(clippy::similar_names, clippy::excessive_precision)]
 
 pub mod scalar;
 pub mod simd;