Do not use vpmin/max to reduce vector masks smaller than 128-bit on ARM+NEON

Author: gnzlbg

src/codegen/reductions/mask/arm.rs

@@ -1,121 +1,5 @@
 //! Mask reductions implementation for `arm` targets
 
-/// ARM m32x2 v7+neon implementation
-macro_rules! arm_m32x2_v7_neon_impl {
-    ($id:ident, $vpmin:ident, $vpmax:ident) => {
-        impl All for $id {
-            #[inline]
-            #[target_feature(enable = "v7,neon")]
-            unsafe fn all(self) -> bool {
-                use crate::arch::arm::$vpmin;
-                use crate::mem::transmute;
-                // pmin((a, b), (-,-)) => (b, -).0 => b
-                let tmp: $id =
-                    transmute($vpmin(transmute(self), crate::mem::uninitialized()));
-                tmp.extract(0)
-            }
-        }
-        impl Any for $id {
-            #[inline]
-            #[target_feature(enable = "v7,neon")]
-            unsafe fn any(self) -> bool {
-                use crate::arch::arm::$vpmax;
-                use crate::mem::transmute;
-                // pmax((a, b), (-,-)) => (b, -).0 => b
-                let tmp: $id =
-                    transmute($vpmax(transmute(self), crate::mem::uninitialized()));
-                tmp.extract(0)
-            }
-        }
-    };
-}
-
-/// ARM m16x4 v7+neon implementation
-macro_rules! arm_m16x4_v7_neon_impl {
-    ($id:ident, $vpmin:ident, $vpmax:ident) => {
-        impl All for $id {
-            #[inline]
-            #[target_feature(enable = "v7,neon")]
-            unsafe fn all(self) -> bool {
-                use crate::arch::arm::$vpmin;
-                use crate::mem::transmute;
-                // tmp = pmin((a, b, c, d), (-,-,-,-)) => (a, c, -, -)
-                let tmp = $vpmin(transmute(self), crate::mem::uninitialized());
-                // tmp = pmin((a, b, -, -), (-,-,-,-)) => (c, -, -, -).0 => c
-                let tmp: $id = transmute($vpmin(tmp, crate::mem::uninitialized()));
-                tmp.extract(0)
-            }
-        }
-        impl Any for $id {
-            #[inline]
-            #[target_feature(enable = "v7,neon")]
-            unsafe fn any(self) -> bool {
-                use crate::arch::arm::$vpmax;
-                use crate::mem::transmute;
-                // tmp = pmax((a, b, c, d), (-,-,-,-)) => (a, c, -, -)
-                let tmp = $vpmax(transmute(self), crate::mem::uninitialized());
-                // tmp = pmax((a, b, -, -), (-,-,-,-)) => (c, -, -, -).0 => c
-                let tmp: $id = transmute($vpmax(tmp, crate::mem::uninitialized()));
-                tmp.extract(0)
-            }
-        }
-    };
-}
-
-/// ARM m8x8 v7+neon implementation
-macro_rules! arm_m8x8_v7_neon_impl {
-    ($id:ident, $vpmin:ident, $vpmax:ident) => {
-        impl All for $id {
-            #[inline]
-            #[target_feature(enable = "v7,neon")]
-            unsafe fn all(self) -> bool {
-                use crate::arch::arm::$vpmin;
-                use crate::mem::transmute;
-                // tmp = pmin(
-                //     (a, b, c, d, e, f, g, h),
-                //     (-, -, -, -, -, -, -, -)
-                // ) => (a, c, e, g, -, -, -, -)
-                let tmp = $vpmin(transmute(self), crate::mem::uninitialized());
-                // tmp = pmin(
-                //     (a, c, e, g, -, -, -, -),
-                //     (-, -, -, -, -, -, -, -)
-                // ) => (c, g, -, -, -, -, -, -)
-                let tmp = $vpmin(tmp, crate::mem::uninitialized());
-                // tmp = pmin(
-                //     (c, g, -, -, -, -, -, -),
-                //     (-, -, -, -, -, -, -, -)
-                // ) => (g, -, -, -, -, -, -, -).0 => g
-                let tmp: $id = transmute($vpmin(tmp, crate::mem::uninitialized()));
-                tmp.extract(0)
-            }
-        }
-        impl Any for $id {
-            #[inline]
-            #[target_feature(enable = "v7,neon")]
-            unsafe fn any(self) -> bool {
-                use crate::arch::arm::$vpmax;
-                use crate::mem::transmute;
-                // tmp = pmax(
-                //     (a, b, c, d, e, f, g, h),
-                //     (-, -, -, -, -, -, -, -)
-                // ) => (a, c, e, g, -, -, -, -)
-                let tmp = $vpmax(transmute(self), crate::mem::uninitialized());
-                // tmp = pmax(
-                //     (a, c, e, g, -, -, -, -),
-                //     (-, -, -, -, -, -, -, -)
-                // ) => (c, g, -, -, -, -, -, -)
-                let tmp = $vpmax(tmp, crate::mem::uninitialized());
-                // tmp = pmax(
-                //     (c, g, -, -, -, -, -, -),
-                //     (-, -, -, -, -, -, -, -)
-                // ) => (g, -, -, -, -, -, -, -).0 => g
-                let tmp: $id = transmute($vpmax(tmp, crate::mem::uninitialized()));
-                tmp.extract(0)
-            }
-        }
-    };
-}
-
 /// Implementation for ARM + v7 + NEON for 64-bit or 128-bit wide vectors with
 /// more than two elements.
 macro_rules! arm_128_v7_neon_impl {
@@ -161,10 +45,6 @@ macro_rules! arm_128_v7_neon_impl {
 
 /// Mask reduction implementation for `arm` targets
 macro_rules! impl_mask_reductions {
-    // 64-bit wide masks
-    (m8x8) => { arm_m8x8_v7_neon_impl!(m8x8, vpmin_u8, vpmax_u8); };
-    (m16x4) => { arm_m16x4_v7_neon_impl!(m16x4, vpmin_u16, vpmax_u16); };
-    (m32x2) => { arm_m32x2_v7_neon_impl!(m32x2, vpmin_u32, vpmax_u32); };
     // 128-bit wide masks
     (m8x16) => { arm_128_v7_neon_impl!(m8x16, m8x8, vpmin_u8, vpmax_u8); };
     (m16x8) => { arm_128_v7_neon_impl!(m16x8, m16x4, vpmin_u16, vpmax_u16); };